From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpbgjp3.qq.com (smtpbgjp3.qq.com [54.92.39.34]) by sourceware.org (Postfix) with ESMTPS id B60B63858C52 for ; Mon, 9 Jan 2023 22:33:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B60B63858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai X-QQ-mid: bizesmtp86t1673303591t9cfh9uj Received: from server1.localdomain ( [58.60.1.22]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 10 Jan 2023 06:33:10 +0800 (CST) X-QQ-SSF: 01400000000000E0L000B00A0000000 X-QQ-FEAT: 0vfWcIgh24wsMxuJPB2lDp0ImUy4e4/sdfj2O6u0pQjXo4MG+DZIdtJk+5Qa+ iIcmEm4y9nX5kOaD+J1Md51BOzQqwtqsuRb2fw+ir8l4oTGsXMaF18Iwqhj3KrzT47Yjxk8 Grr/3sKXM7vLNsPoptrgfACqhL4uYK7I992pXjCrC2X8KRq14VP95C49PAvPBo/x+mOSpXG PNZMFa6Ii0IauC02ICf3f/ebbfD5aSMM0ZIzHx9qAZSSn/Dl+4wwzcy3YoBNJMibtOt4coN k9aVHzRm4MuqlJ5hZ3AW/h23iQZ9m11snXLhcHjKC4g2T5XdK7CAFvruBFqIFko1o3tMJor O8jdVXwfnut2qPoNX9ybVuO2EFulENqosaMzkhM X-QQ-GoodBg: 2 From: juzhe.zhong@rivai.ai To: gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, palmer@dabbelt.com, Ju-Zhe Zhong Subject: [PATCH] RISC-V: Cleanup the codes of bitmap create and free [NFC] Date: Tue, 10 Jan 2023 06:33:07 +0800 Message-Id: <20230109223307.144358-1-juzhe.zhong@rivai.ai> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvr:qybglogicsvr7 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Ju-Zhe Zhong This patch is a NFC patch to move the codes into a wrapper function so that they can be reused. I will reuse them in the following patches. gcc/ChangeLog: * config/riscv/riscv-vsetvl.cc (vector_infos_manager::create_bitmap_vectors): New function. (vector_infos_manager::free_bitmap_vectors): Ditto. (pass_vsetvl::pre_vsetvl): Adjust codes. * config/riscv/riscv-vsetvl.h: New function declaration. --- gcc/config/riscv/riscv-vsetvl.cc | 95 +++++++++++++++++++------------- gcc/config/riscv/riscv-vsetvl.h | 2 + 2 files changed, 59 insertions(+), 38 deletions(-) diff --git a/gcc/config/riscv/riscv-vsetvl.cc b/gcc/config/riscv/riscv-vsetvl.cc index d42cfa91d63..7800c2ee509 100644 --- a/gcc/config/riscv/riscv-vsetvl.cc +++ b/gcc/config/riscv/riscv-vsetvl.cc @@ -1569,18 +1569,62 @@ vector_infos_manager::release (void) vector_exprs.release (); if (optimize > 0) - { - /* Finished. Free up all the things we've allocated. */ - free_edge_list (vector_edge_list); - sbitmap_vector_free (vector_del); - sbitmap_vector_free (vector_insert); - sbitmap_vector_free (vector_kill); - sbitmap_vector_free (vector_antic); - sbitmap_vector_free (vector_transp); - sbitmap_vector_free (vector_comp); - sbitmap_vector_free (vector_avin); - sbitmap_vector_free (vector_avout); - } + free_bitmap_vectors (); +} + +void +vector_infos_manager::create_bitmap_vectors (void) +{ + /* Create the bitmap vectors. */ + vector_antic = sbitmap_vector_alloc (last_basic_block_for_fn (cfun), + vector_exprs.length ()); + vector_transp = sbitmap_vector_alloc (last_basic_block_for_fn (cfun), + vector_exprs.length ()); + vector_comp = sbitmap_vector_alloc (last_basic_block_for_fn (cfun), + vector_exprs.length ()); + vector_avin = sbitmap_vector_alloc (last_basic_block_for_fn (cfun), + vector_exprs.length ()); + vector_avout = sbitmap_vector_alloc (last_basic_block_for_fn (cfun), + vector_exprs.length ()); + vector_kill = sbitmap_vector_alloc (last_basic_block_for_fn (cfun), + vector_exprs.length ()); + + bitmap_vector_ones (vector_transp, last_basic_block_for_fn (cfun)); + bitmap_vector_clear (vector_antic, last_basic_block_for_fn (cfun)); + bitmap_vector_clear (vector_comp, last_basic_block_for_fn (cfun)); +} + +void +vector_infos_manager::free_bitmap_vectors (void) +{ + /* Finished. Free up all the things we've allocated. */ + free_edge_list (vector_edge_list); + if (vector_del) + sbitmap_vector_free (vector_del); + if (vector_insert) + sbitmap_vector_free (vector_insert); + if (vector_kill) + sbitmap_vector_free (vector_kill); + if (vector_antic) + sbitmap_vector_free (vector_antic); + if (vector_transp) + sbitmap_vector_free (vector_transp); + if (vector_comp) + sbitmap_vector_free (vector_comp); + if (vector_avin) + sbitmap_vector_free (vector_avin); + if (vector_avout) + sbitmap_vector_free (vector_avout); + + vector_edge_list = nullptr; + vector_kill = nullptr; + vector_del = nullptr; + vector_insert = nullptr; + vector_antic = nullptr; + vector_transp = nullptr; + vector_comp = nullptr; + vector_avin = nullptr; + vector_avout = nullptr; } void @@ -2480,32 +2524,7 @@ pass_vsetvl::pre_vsetvl (void) /* Compute entity list. */ prune_expressions (); - /* Create the bitmap vectors. */ - m_vector_manager->vector_antic - = sbitmap_vector_alloc (last_basic_block_for_fn (cfun), - m_vector_manager->vector_exprs.length ()); - m_vector_manager->vector_transp - = sbitmap_vector_alloc (last_basic_block_for_fn (cfun), - m_vector_manager->vector_exprs.length ()); - m_vector_manager->vector_comp - = sbitmap_vector_alloc (last_basic_block_for_fn (cfun), - m_vector_manager->vector_exprs.length ()); - m_vector_manager->vector_avin - = sbitmap_vector_alloc (last_basic_block_for_fn (cfun), - m_vector_manager->vector_exprs.length ()); - m_vector_manager->vector_avout - = sbitmap_vector_alloc (last_basic_block_for_fn (cfun), - m_vector_manager->vector_exprs.length ()); - m_vector_manager->vector_kill - = sbitmap_vector_alloc (last_basic_block_for_fn (cfun), - m_vector_manager->vector_exprs.length ()); - - bitmap_vector_ones (m_vector_manager->vector_transp, - last_basic_block_for_fn (cfun)); - bitmap_vector_clear (m_vector_manager->vector_antic, - last_basic_block_for_fn (cfun)); - bitmap_vector_clear (m_vector_manager->vector_comp, - last_basic_block_for_fn (cfun)); + m_vector_manager->create_bitmap_vectors (); compute_local_properties (); m_vector_manager->vector_edge_list = pre_edge_lcm_avs ( m_vector_manager->vector_exprs.length (), m_vector_manager->vector_transp, diff --git a/gcc/config/riscv/riscv-vsetvl.h b/gcc/config/riscv/riscv-vsetvl.h index 33481a87163..dc16c55b918 100644 --- a/gcc/config/riscv/riscv-vsetvl.h +++ b/gcc/config/riscv/riscv-vsetvl.h @@ -341,6 +341,8 @@ public: bool all_same_ratio_p (sbitmap) const; void release (void); + void create_bitmap_vectors (void); + void free_bitmap_vectors (void); void dump (FILE *) const; }; -- 2.36.1