From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 53DE33858407 for ; Tue, 10 Jan 2023 13:21:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 53DE33858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 30ADK4kf026212; Tue, 10 Jan 2023 07:20:04 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 30ADK3Wi026211; Tue, 10 Jan 2023 07:20:03 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Tue, 10 Jan 2023 07:20:03 -0600 From: Segher Boessenkool To: Adhemerval Zanella Netto Cc: joseph_myers@mentor.com, Richard Biener , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] longlong.h: Do no use asm input cast for clang Message-ID: <20230110132003.GQ25951@gate.crashing.org> References: <20221130181625.2011166-1-adhemerval.zanella@linaro.org> <20221130232456.GT25951@gate.crashing.org> <3e4bc189-7d73-f875-b425-61dde1a86e34@linaro.org> <20221212235240.GF25951@gate.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On Tue, Jan 10, 2023 at 09:26:13AM -0300, Adhemerval Zanella Netto wrote: > On 12/12/22 20:52, Segher Boessenkool wrote: > > On Mon, Dec 12, 2022 at 02:10:16PM -0300, Adhemerval Zanella Netto wrote: > > How do you intend to modify all the existing copies of the header that > > haven't been updated for over a decade already?> > > If you think changing all user code that uses longlong.h is a good idea, > > please change it to not use inline asm, use builtins in some cases but > > mostly just rewrite things in plain C. But GCC cannot rewrite user code > > (not preemptively anyway ;-) ) -- and longlong.h as encountered in the > > wild (not the one in our libgcc source code) is user code. > > > > If you think changing the copy in libgcc is a good idea, please change > > the original in glibc first? > > That's my original intention [1], but Joseph stated that GCC is the upstream > source of this file. Joseph, would you be ok for a similar patch to glibc > since gcc is reluctant to accept it? > > [1] https://sourceware.org/pipermail/libc-alpha/2022-October/143050.html The file starts with /* longlong.h -- definitions for mixed size 32/64 bit arithmetic. Copyright (C) 1991-2022 Free Software Foundation, Inc. This file is part of the GNU C Library. Please change that first then? Segher