From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 84D193858D32 for ; Mon, 16 Jan 2023 15:25:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84D193858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 30GFOw8S001328; Mon, 16 Jan 2023 09:24:59 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 30GFOw42001327; Mon, 16 Jan 2023 09:24:58 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Mon, 16 Jan 2023 09:24:58 -0600 From: Segher Boessenkool To: "Kewen.Lin" Cc: GCC Patches , David Edelsohn , Peter Bergner Subject: Re: [PATCH] rs6000: Teach rs6000_opaque_type_invalid_use_p about gcall [PR108348] Message-ID: <20230116152458.GH25951@gate.crashing.org> References: <1ea87e1b-7caf-59dd-ff1a-8f282a2dae14@linux.ibm.com> <20230116084907.GE25951@gate.crashing.org> <20230116104051.GG25951@gate.crashing.org> <2422e203-d2bb-30a4-efac-55972c96e074@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2422e203-d2bb-30a4-efac-55972c96e074@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jan 16, 2023 at 09:05:38PM +0800, Kewen.Lin wrote: > > The *_ok things should only be used for features that can be disabled > > during configuration, or features that we *want* users to be able to > > turn off (like FP, VMX, VSX, or HMT or QP float, that kind of thing). > > That gives quite enough permutations to test already, we do not need to > > create a whole bunch extra for no reason :-) > > Thanks for the explanation!! I meant to use powerpc_p9modulo_ok to > exclude those cases where we can't use -mcpu=power9, as you explained we > should not worry about it!? But that selector says whether modulo insns are enabled. This is not correct to use here. I know we have abused these things before, but it needs to be untangled, not made worse :-) > Since the test point requires altivec support > (which is implied when specifying -mcpu=power9, I didn't explicitly specify > it before), I think I could use powerpc_altivec_ok to replace > powerpc_p9modulo_ok here, does it sound good to you? VMX can be turned off even with -mcpu=power9. So yes, it does need powerpc_altivec_ok. Does it need VSX even? Segher