From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 1BFBB3858C2C for ; Thu, 19 Jan 2023 20:21:03 +0000 (GMT) Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1pIbPB-0001ws-Sq for gcc-patches@gcc.gnu.org; Thu, 19 Jan 2023 21:21:01 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Harald Anlauf Subject: Re: git out-of-order commit (was Re: [PATCH] Fortran: Remove unused declaration) Date: Thu, 19 Jan 2023 21:20:54 +0100 Message-ID: <1dd13478-afd8-0d72-7d38-8ba51a819bd1@gmx.de> References: <20221112210535.45202-1-aldot@gcc.gnu.org> <933d0150-32fd-84df-6a8a-a19f8c7d6dbc@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US In-Reply-To: Cc: fortran@gcc.gnu.org X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20230119202054.FAXlOd02I58j9zmb8YoTpeMT_jBs1yGu73QzliL-bMM@z> Am 19.01.23 um 20:39 schrieb Jason Merrill via Gcc-patches: > On Sat, Nov 12, 2022 at 4:24 PM Harald Anlauf via Gcc-patches > wrote: >> >> Am 12.11.22 um 22:05 schrieb Bernhard Reutner-Fischer via Gcc-patches: >>> This function definition was removed years ago, remove it's prototype. >>> >>> gcc/fortran/ChangeLog: >>> >>> * gfortran.h (gfc_check_include): Remove declaration. >>> --- >>> gcc/fortran/gfortran.h | 1 - >>> 1 file changed, 1 deletion(-) >>> --- >>> Regtests cleanly, ok for trunk? >>> >>> diff --git a/gcc/fortran/gfortran.h b/gcc/fortran/gfortran.h >>> index c4deec0d5b8..ce3ad61bb52 100644 >>> --- a/gcc/fortran/gfortran.h >>> +++ b/gcc/fortran/gfortran.h >>> @@ -3208,7 +3208,6 @@ int gfc_at_eof (void); >>> int gfc_at_bol (void); >>> int gfc_at_eol (void); >>> void gfc_advance_line (void); >>> -int gfc_check_include (void); >>> int gfc_define_undef_line (void); >>> >>> int gfc_wide_is_printable (gfc_char_t); >> >> OK, thanks. > > Somehow this was applied with a CommitDate in 2021, breaking scripts > that assume monotonically increasing CommitDate. Anyone know how that > could have happened? It is quite unusual that the CommitDate is before the AuthorDate: % git show --pretty=fuller 7ce0cee77adf33397d0ba61e7445effd8a5d8fcc | head -5 commit 7ce0cee77adf33397d0ba61e7445effd8a5d8fcc Author: Bernhard Reutner-Fischer AuthorDate: Sat Nov 6 06:51:00 2021 +0100 Commit: Bernhard Reutner-Fischer CommitDate: Sat Nov 6 06:48:00 2021 +0100 Could this have prevented checks to work properly? Harald > Jason > >