From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 7A6AD3858D32 for ; Mon, 23 Jan 2023 10:09:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A6AD3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 837DF34216; Mon, 23 Jan 2023 10:09:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674468583; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=freEcMmBIe+X40LrAkqCTG92yIwUp81JMgy1d0/Y/n4=; b=MTEHCMJVyyepbYksBnd6rISdRzQy+vq1fWXvj1vWF85FDWLHfdrG7kTQTW9KYHS8CP/U/Z C4NzFCn9nbtkLXDOz5KmGsqXXIZwL/FN8vSxZYDl+V3E0R4SjPvU5RoVwYSOUDEdq7KSd7 B4aDSkXoZuxGsN/y5H43JUVmdPsMgK4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674468583; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=freEcMmBIe+X40LrAkqCTG92yIwUp81JMgy1d0/Y/n4=; b=hCpZUFQAS0ak6mh2KVlrL8TrE+QFSRRkvkiYdmoVAqu5ZzkRQdAPB/EBIydwXcJyQjyLCo oUJwdVM5GM1JsVAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6C675134F5; Mon, 23 Jan 2023 10:09:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id FaxVGedczmPzEQAAMHmgww (envelope-from ); Mon, 23 Jan 2023 10:09:43 +0000 Date: Mon, 23 Jan 2023 11:09:43 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: Jakub Jelinek Subject: [PATCH] tree-optimization/108482 - remove stray .LOOP_DIST_ALIAS calls MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Message-Id: <20230123100943.6C675134F5@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The following deals with .LOOP_DIST_ALIAS surviving vectorization because any of the loops involved were elided between loop distribution and vectorization. As opposed to .LOOP_VECTORIZED which exists only between if-conversion and vectorization with no intermediate passes this is more difficult to deal with in advance and thus cleaning up after vectorization looks better. There's the unconditional vector lowering pass which looks like a good place for this (for SIMD uid we have pass_simduid_cleanup). Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. OK? Thanks, Richard. PR tree-optimization/108482 * tree-vect-generic.cc (expand_vector_operations): Fold remaining .LOOP_DIST_ALIAS calls. * gcc.dg/torture/pr108482.c: New testcase. --- gcc/testsuite/gcc.dg/torture/pr108482.c | 18 ++++++++++++++++++ gcc/tree-vect-generic.cc | 8 ++++++++ 2 files changed, 26 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/torture/pr108482.c diff --git a/gcc/testsuite/gcc.dg/torture/pr108482.c b/gcc/testsuite/gcc.dg/torture/pr108482.c new file mode 100644 index 00000000000..8dc1169a9c5 --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr108482.c @@ -0,0 +1,18 @@ +/* { dg-do compile } */ + +int g_30, g_261, g_263, func_1___trans_tmp_17; +int **g_120; +int *g_530; +void func_1() { + int *l_29 = &g_30; + *l_29 = 1; + g_263 = 0; + for (; g_263 <= 1; g_263 += 1) { + g_530 = 0; + if (*l_29) { + char *l_1694 = (char *)&g_261; + *l_1694 &= **g_120; + } else + *l_29 ^= func_1___trans_tmp_17; + } +} diff --git a/gcc/tree-vect-generic.cc b/gcc/tree-vect-generic.cc index 2e2d7567293..166a248f4b9 100644 --- a/gcc/tree-vect-generic.cc +++ b/gcc/tree-vect-generic.cc @@ -2398,6 +2398,14 @@ expand_vector_operations (void) if (maybe_clean_eh_stmt (gsi_stmt (gsi)) && gimple_purge_dead_eh_edges (bb)) cfg_changed = true; + /* If a .LOOP_DIST_ALIAS call prevailed loops got elided + before vectorization got a chance to get at them. Simply + fold as if loop distribution wasn't performed. */ + if (gimple_call_internal_p (gsi_stmt (gsi), IFN_LOOP_DIST_ALIAS)) + { + fold_loop_internal_call (gsi_stmt (gsi), boolean_false_node); + cfg_changed = true; + } } } -- 2.35.3