From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 59BAD3858D38 for ; Thu, 26 Jan 2023 12:49:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 59BAD3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 92C1C1FF40 for ; Thu, 26 Jan 2023 12:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674737344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=5+fo4JygnbbzuF5QHlBgHYIY/GDH5MfdWkNZGrEpbXY=; b=C88KR5sv8q8D5Caz8xCfR2V2Md52oq1e/yGkht6mwzfDGz+W24icO0fO96CALuHU+0auNl ie8wjyMCXSsIM246mJWwHG6G0cBp6uHkgrswJOKEEir0M+5UcL6tSAvW4pb1p+vMEBvOKv WR19NwRMu6UTK/SfI72/hWS7fYK8msc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674737344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=5+fo4JygnbbzuF5QHlBgHYIY/GDH5MfdWkNZGrEpbXY=; b=XEFd3ot9RH6IRNWMgeEaOsDn9abcxy1KqDSgaC9p7flmC3OQb1rL72xheog9z8vHBjBjOO zLR3Jds7VdefVeDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 81D8013A09 for ; Thu, 26 Jan 2023 12:49:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dxzIHsB20mNYTAAAMHmgww (envelope-from ) for ; Thu, 26 Jan 2023 12:49:04 +0000 Date: Thu, 26 Jan 2023 13:49:04 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/108547 - robustify uninit predicate analysis MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Message-Id: <20230126124904.81D8013A09@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Predicate analysis, when looking through casts doesn't bother to convert boundary constants to the type of the bounded variables. The following robustifies value_sat_pred_p to use widest_ints to deal with this, like other code in predicate analysis. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/108547 * gimple-predicate-analysis.cc (value_sat_pred_p): Use widest_int. * gcc.dg/uninit-pr108547.c: New testcase. --- gcc/gimple-predicate-analysis.cc | 6 +++--- gcc/testsuite/gcc.dg/uninit-pr108547.c | 24 ++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/uninit-pr108547.c diff --git a/gcc/gimple-predicate-analysis.cc b/gcc/gimple-predicate-analysis.cc index a7719ff493f..094e8c7aff3 100644 --- a/gcc/gimple-predicate-analysis.cc +++ b/gcc/gimple-predicate-analysis.cc @@ -728,11 +728,11 @@ value_sat_pred_p (tree val, tree boundary, tree_code cmpc, if (cmpc != BIT_AND_EXPR) return is_value_included_in (val, boundary, cmpc); - wide_int andw = wi::to_wide (val) & wi::to_wide (boundary); + widest_int andw = wi::to_widest (val) & wi::to_widest (boundary); if (exact_p) - return andw == wi::to_wide (val); + return andw == wi::to_widest (val); - return andw.to_uhwi (); + return wi::ne_p (andw, 0); } /* Return true if the domain of single predicate expression PRED1 diff --git a/gcc/testsuite/gcc.dg/uninit-pr108547.c b/gcc/testsuite/gcc.dg/uninit-pr108547.c new file mode 100644 index 00000000000..d8f6c9ff87a --- /dev/null +++ b/gcc/testsuite/gcc.dg/uninit-pr108547.c @@ -0,0 +1,24 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -Wuninitialized" } */ + +int func_7_uc_10li_19 (int); +int li_4, li_5, us_8; +unsigned char func_7_ptr_13, func_7_uc_14; +void func_7_ptr_18() { + if (li_5) { + for (;;) + ; + short s_15; + for (; func_7_uc_14;) { + us_8 = 7; + for (; us_8; us_8 += 1) + lblD2AF1FAB: + if (us_8) + li_4 = 1; + func_7_uc_14 += (__INTPTR_TYPE__)func_7_ptr_18; + if (func_7_ptr_13 & 1 && (func_7_uc_14 &= func_7_ptr_13)) + s_15 %= func_7_uc_10li_19(s_15); /* { dg-warning "uninitialized" } */ + } + } + goto lblD2AF1FAB; +} -- 2.35.3