From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [COMMITTED] bpf: disable -fstack-protector in BPF
Date: Sat, 28 Jan 2023 15:12:55 +0100 [thread overview]
Message-ID: <20230128141255.nps3jzmcfmp2df3z@lug-owl.de> (raw)
In-Reply-To: <20230117162508.74789-1-jose.marchesi@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]
On Tue, 2023-01-17 17:25:08 +0100, Jose E. Marchesi via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
> The stack protector is not supported in BPF. This patch disables
> -fstack-protector in bpf-* targets, along with the emission of a note
> indicating that the feature is not supported in this platform.
[...]
> diff --git a/gcc/config/bpf/bpf.cc b/gcc/config/bpf/bpf.cc
> index 576a1fe8eab..b268801d00c 100644
> --- a/gcc/config/bpf/bpf.cc
> +++ b/gcc/config/bpf/bpf.cc
> @@ -253,6 +253,14 @@ bpf_option_override (void)
> if (bpf_has_jmp32 == -1)
> bpf_has_jmp32 = (bpf_isa >= ISA_V3);
>
> + /* Disable -fstack-protector as it is not supported in BPF. */
> + if (flag_stack_protect)
> + {
> + inform (input_location,
> + "%<-fstack-protector%> does not work "
> + " on this architecture");
> + flag_stack_protect = 0;
> + }
Building with a recent GCC with (noticed during a -Werror build), this
results in a new warning:
[all 2023-01-27 16:26:25] ../../gcc/gcc/config/bpf/bpf.cc: In function 'void bpf_option_override()':
[all 2023-01-27 16:26:25] ../../gcc/gcc/config/bpf/bpf.cc:260:51: error: unquoted sequence of 2 consecutive space characters in format [-Werror=format-diag]
[all 2023-01-27 16:26:25] 260 | "%<-fstack-protector%> does not work "
[all 2023-01-27 16:26:25] | ^~
[all 2023-01-27 16:26:25] 261 | " on this architecture");
[all 2023-01-27 16:26:25] | ~~
[all 2023-01-27 16:26:27] cc1plus: all warnings being treated as errors
MfG, JBG
--
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-01-28 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 16:25 Jose E. Marchesi
2023-01-28 14:12 ` Jan-Benedict Glaw [this message]
2023-02-15 10:02 ` [patch] bpf: Fix double whitespace warning Jan-Benedict Glaw
2023-02-15 10:49 ` Jose E. Marchesi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230128141255.nps3jzmcfmp2df3z@lug-owl.de \
--to=jbglaw@lug-owl.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jose.marchesi@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).