From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 803373858D33 for ; Tue, 31 Jan 2023 20:41:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 803373858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675197702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8v6AEyyxITfudUk2+jdOXSM+B0wO6rNSKaIaCW8dbt8=; b=OWV0oSd394aXuuIVgdxj0ZwOPgpeutbVo9I5PN2TOyFM8o21bJ9D+qK2QaZYdSHrjkkh6u Yzj43qkJzxH5a7sieMSe++nIdh3z+OsRYowz9+2mTfqvtbTGnLOAhTxzvaLc8NL7nUrrE9 oMR6bZS1DZdp6f1zTWSmceBB9gil3Io= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-642-Qln3guJvNVuyR8bt4ENkVQ-1; Tue, 31 Jan 2023 15:41:41 -0500 X-MC-Unique: Qln3guJvNVuyR8bt4ENkVQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D0B6D281DE67 for ; Tue, 31 Jan 2023 20:41:40 +0000 (UTC) Received: from pdp-11.lan (unknown [10.22.33.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id B3875140EBF4; Tue, 31 Jan 2023 20:41:40 +0000 (UTC) From: Marek Polacek To: Jason Merrill , GCC Patches Subject: [PATCH] c++: ICE with -Wlogical-op [PR107755] Date: Tue, 31 Jan 2023 15:41:34 -0500 Message-Id: <20230131204134.725217-1-polacek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Here we crash in the middle end because warn_logical_operator calls build_range_check which calls various fold_* functions and those don't work too well when we're still processing template trees. For instance here we crash because we're converting a RECORD_TYPE to bool. At this point VIEW_CONVERT_EXPR(b) hasn't yet been converted to Foo::operator bool (&b). I was excited to fix this with instantiation_dependent_expression_p which can now be called from c-family/ as well, but the problem isn't that the expression is dependent. So, p_t_d it is. Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? PR c++/107755 gcc/cp/ChangeLog: * call.cc (build_new_op): Don't call warn_logical_operator when processing a template. gcc/testsuite/ChangeLog: * g++.dg/warn/Wlogical-op-4.C: New test. --- gcc/cp/call.cc | 2 +- gcc/testsuite/g++.dg/warn/Wlogical-op-4.C | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/warn/Wlogical-op-4.C diff --git a/gcc/cp/call.cc b/gcc/cp/call.cc index 5715a7cd1de..f7c5d9da94b 100644 --- a/gcc/cp/call.cc +++ b/gcc/cp/call.cc @@ -7335,7 +7335,7 @@ build_new_op (const op_location_t &loc, enum tree_code code, int flags, case TRUTH_ORIF_EXPR: case TRUTH_AND_EXPR: case TRUTH_OR_EXPR: - if (complain & tf_warning) + if ((complain & tf_warning) && !processing_template_decl) warn_logical_operator (loc, code, boolean_type_node, code_orig_arg1, arg1, code_orig_arg2, arg2); diff --git a/gcc/testsuite/g++.dg/warn/Wlogical-op-4.C b/gcc/testsuite/g++.dg/warn/Wlogical-op-4.C new file mode 100644 index 00000000000..745c9117a3d --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/Wlogical-op-4.C @@ -0,0 +1,23 @@ +// PR c++/107755 +// { dg-do compile } +// { dg-options "-Wlogical-op" } + +struct Foo +{ + operator bool() const { return false; } +}; + +bool a; +Foo b; + +template +static bool Bar() +{ + return (true && (false ? a : b)); + return (false || (false ? a : b)); +} + +bool Baz() +{ + return Bar(); +} base-commit: b2ec2504af77b35e748067eeb846821d12a6b6b4 -- 2.39.1