From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 30C0D3858C74 for ; Thu, 2 Feb 2023 14:15:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 30C0D3858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675347316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xxy9U0T0sA7hpxU62t0HxMm/W5i/WHBfa8Itd2Qp9WU=; b=gW67nDGBaF4xekyU/9Vu/c3FbjkOr5jVTjpgj0hSlIyC1xUFJpUg75/1ya+rGdRI8ufb80 /MnV+Esys1k/iUbh+edYA3sFIk6TrxVkPL4QHhQKGv8y0awJ04Mo91ShtPH8wqkJfRiP6Z YyozM0Doozb+jafcVKzQYHY7sOwHWGI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-672-8eqfwLynPgCoycJ3pvxCPg-1; Thu, 02 Feb 2023 09:15:06 -0500 X-MC-Unique: 8eqfwLynPgCoycJ3pvxCPg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 67DD2801CF6 for ; Thu, 2 Feb 2023 14:15:05 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.2.17.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 409D851E5; Thu, 2 Feb 2023 14:15:05 +0000 (UTC) From: David Malcolm To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [pushed] analyzer: add deref-before-check-qemu-qtest_rsp_args.c test case Date: Thu, 2 Feb 2023 09:15:03 -0500 Message-Id: <20230202141503.913418-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Successfully regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r13-5654-g598e10cf415f0a. gcc/testsuite/ChangeLog: * gcc.dg/analyzer/deref-before-check-qemu-qtest_rsp_args.c: New test. Signed-off-by: David Malcolm --- .../deref-before-check-qemu-qtest_rsp_args.c | 73 +++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/analyzer/deref-before-check-qemu-qtest_rsp_args.c diff --git a/gcc/testsuite/gcc.dg/analyzer/deref-before-check-qemu-qtest_rsp_args.c b/gcc/testsuite/gcc.dg/analyzer/deref-before-check-qemu-qtest_rsp_args.c new file mode 100644 index 00000000000..2b3ad8c5fb3 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/deref-before-check-qemu-qtest_rsp_args.c @@ -0,0 +1,73 @@ +/* Reduced from qemu-7.2.0's tests/qtest/libqtest.c. */ + +#define TRUE 1 +#define NULL ((void *)0) + +#define g_assert(expr) \ + do { \ + if (expr) ; else /* { dg-warning "check of '\\*words' for NULL after already dereferencing it" } */ \ + g_assertion_message_expr (#expr); \ +} while (0) + +void g_assertion_message_expr (const char *expr) __attribute__((noreturn)); + +extern int strcmp (const char *__s1, const char *__s2) + __attribute__ ((__nothrow__ , __leaf__, __pure__, __nonnull__ (1, 2))); +typedef char gchar; +typedef int gint; +typedef gint gboolean; +typedef struct _GString GString; + +struct _GString +{ + gchar *str; + /* [...snip...] */ +}; + +extern +gchar* g_string_free (GString *string, + gboolean free_segment); +extern +gchar** g_strsplit (const gchar *string, + const gchar *delimiter, + gint max_tokens); +extern +void g_strfreev (gchar **str_array); + +typedef struct QTestState QTestState; +typedef GString* (*QTestRecvFn)(QTestState *); + +typedef struct QTestClientTransportOps { + /* [...snip...] */ + QTestRecvFn recv_line; +} QTestTransportOps; + +struct QTestState +{ + /* [...snip...] */ + QTestTransportOps ops; + /* [...snip...] */ +}; + +gchar **qtest_rsp_args(QTestState *s, int expected_args) +{ + GString *line; + gchar **words; + /* [...snip...] */ + +redo: + line = s->ops.recv_line(s); + words = g_strsplit(line->str, " ", 0); + g_string_free(line, TRUE); + + if (strcmp(words[0], "IRQ") == 0) { /* { dg-message "pointer '\\*words' is dereferenced here" } */ + /* [...snip...] */ + g_strfreev(words); + goto redo; + } + + g_assert(words[0] != NULL); /* { dg-message "in expansion of macro 'g_assert'" } */ + /* [...snip...] */ + + return words; +} -- 2.26.3