From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by sourceware.org (Postfix) with ESMTPS id 035783858D33 for ; Tue, 7 Feb 2023 18:03:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 035783858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1675793025; x=1707329025; h=from:to:cc:in-reply-to:subject:mime-version: content-transfer-encoding:references:message-id:date; bh=VWi5DKEAG6KaZkxgdzjFjNzV3V1hTFlpmKbjnRQDlp0=; b=fRrxKT9Z6bQUFEdVV/T6e/ceN5j9p1BOOUcoCwWcX9Lw0QCuj6Nx0QHD spkFrZ5HkCzV9Qgf/5MDYiYeJy/1ARqwkmoprNt28IKRqUIbgeBjz1PA4 Y8UYRPVCpTRLc15/NoFNyITmhqJcbSsrKVaR5gFkb5NLzqFzUVGJQCgdx IDJMdeYbiUxUEWDEwokKHwCQAJDRSGwVd7GSdZxKLyXCakLAqQmtq3cJL VYOtYGFHwbfmAQfMsQWI+wmnB/4TOmn+yP2JeeEUcdkvtjEFnCgsXQZwM J8eaJFTVefKJtisGJOYsmpcXLiQagMCFHxqcElroZN0FG4Ru6613Xvo/m w==; From: Hans-Peter Nilsson To: Aldy Hernandez CC: In-Reply-To: <2f53f322-76b9-12e6-4c4a-23352e957d6c@redhat.com> (message from Aldy Hernandez on Tue, 7 Feb 2023 17:52:02 +0100) Subject: Re: [PATCH] testsuite: XFAIL bogus g++.dg/warn/Wstringop-overflow-4.C:144, PR106120 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20230207165000.AC93020426@pchp3.se.axis.com> <2f53f322-76b9-12e6-4c4a-23352e957d6c@redhat.com> Message-ID: <20230207180342.53BCB2042C@pchp3.se.axis.com> Date: Tue, 7 Feb 2023 19:03:42 +0100 X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Aldy Hernandez > Date: Tue, 7 Feb 2023 17:52:02 +0100 > Up to the release managers, but I have no objections. I take it that's for both patches. Thanks! (Potential reviewers: these patches are local to the testsuite.) brgds, H-P > > Aldy > > On 2/7/23 17:50, Hans-Peter Nilsson wrote: > > (sort-of-ping:) Aldy, I missed CC:ing you on the similar > > https://gcc.gnu.org/pipermail/gcc-patches/2023-February/611206.html > > would you mind having a look? > > > > Tested native x86_64-pc-linux-gnu (w/wo. -m32) and cris-elf. > > Ok to commit? > > > > ---- 8< ---- > > There was a commit r13-2082-gbf13a13c65bd06 "c++: remove some xfails" > > (not referencing the PR) that dealt with part of the PR, but didn't > > xfail the ilp32-specific (bogus) warning mentioned in the PR. > > > > PR testsuite/106120 > > * g++.dg/warn/Wstringop-overflow-4.C:144 XFAIL bogus warning for > > ilp32 targets with c++98. > > --- > > gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C b/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C > > index 3716d2d13be0..35fb59e02320 100644 > > --- a/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C > > +++ b/gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C > > @@ -141,7 +141,7 @@ void test_strcpy_new_int16_t (size_t n, const size_t vals[]) > > > > int r_imin_imax = SR (INT_MIN, INT_MAX); > > T (S (1), new int16_t[r_imin_imax]); > > - T (S (2), new int16_t[r_imin_imax + 1]); > > + T (S (2), new int16_t[r_imin_imax + 1]); // { dg-bogus "into a region of size" "pr106120" { xfail { ilp32 && c++98_only } } } > > T (S (9), new int16_t[r_imin_imax * 2 + 1]); > > > > int r_0_imax = SR (0, INT_MAX); >