From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by sourceware.org (Postfix) with ESMTPS id AC9D53858D1E for ; Wed, 15 Feb 2023 00:18:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AC9D53858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1676420296; x=1707956296; h=from:to:subject:mime-version:content-transfer-encoding: message-id:date; bh=6DXO/etVch7kjDi20pltA73j7qdow8VmB0YI1S6sN0I=; b=glbvP0Up7SmCmLH9QdxBqlg3yXSdTFfK5a34RlJ6OUKjXHZzWKVRfhi1 kx4YiqtHMC8ksGfxBrJrt/figEf4QKRJ+AD8uJoBXPcFfgPKKnVM/mp6u gPTR1yotxkfOb9KDqVFZdzChu+AJ/7/WBB8snaGhpBG2HIh6LPZ74Btfj 0T3mgBZoI4cbp+D6VhEFb9PwMEnHmSwAOiCX+kUtWWqneMwOKToR3A7ct YbH00gZvBV7FDvlwvA875bw4kZ8ThvIME91KGS9iemhbUw+7tbQBKT4EO p88xYstnBODZsmStDXDuJj3RVVTCN8JSpAi1exHpYsOkxBhvkOY5p54AD w==; From: Hans-Peter Nilsson To: Subject: [PATCH] gen_reload: Correct parameter for fatal_insn call MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Message-ID: <20230215001814.F3BAB2042C@pchp3.se.axis.com> Date: Wed, 15 Feb 2023 01:18:14 +0100 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Committed as obvious. Also, I wrote the neighboring code - apparently including that line... -- >8 -- Observed when disabling LEGITIMIZE_RELOAD_ADDRESS for cris-elf: the current code doesn't handle the post-cc0 parallel-with-clobber-of-cc0 sets, dropping down into the fatal_insn call. Following the code, it's obvious that the variable "set" is always NULL at the call. The intended parameter is "in". * reload1.cc (gen_reload): Correct rtx parameter for fatal_insn "failure trying to reload" call. --- gcc/reload1.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/reload1.cc b/gcc/reload1.cc index 6fe22d8b81f9..7dcef50437b8 100644 --- a/gcc/reload1.cc +++ b/gcc/reload1.cc @@ -8606,7 +8606,7 @@ gen_reload (rtx out, rtx in, int opnum, enum reload_type type) return insn; } - fatal_insn ("failure trying to reload:", set); + fatal_insn ("failure trying to reload:", in); } /* If IN is a simple operand, use gen_move_insn. */ else if (OBJECT_P (in) || GET_CODE (in) == SUBREG) -- 2.30.2