From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by sourceware.org (Postfix) with ESMTPS id 1494E3858D33 for ; Wed, 22 Feb 2023 17:53:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1494E3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1677088430; x=1708624430; h=from:to:in-reply-to:subject:mime-version: content-transfer-encoding:references:message-id:date; bh=bhGTBM9e7BN8KgdmIZdETewe/wKZ985+wHLKAE+8UiA=; b=Mqm81F0N8xm2eKyCtUVmpAL59ZZMB0cVw5FcFCXf6BJgleB3dljIv1BI 7gzKnwxOqkxNlybJUqWQfZe3nQyzesFeUjBtlBrhFKbHen5kwUXPhCv/C TV/A3SK6Q2kHvj1j58XDBstme0W29Ed5U00lgG5d/uXNUqHQTxfW2CIaJ u8xG53r3BZinhCtDCoKhRtJiDvYQKthaog9hKVmFL4tBmQBmZ0+wRUDpu 1TCjV5574yFfQaLIeDfGC0Mgt7YOzwUO9UygWwyqss2/pUhkNwfxAGJ+U dgk8yColLz+drLXKb4dWTDi4QucCg2TOCJDkQBPE410Q1dNuzjEreJ2XZ g==; From: Hans-Peter Nilsson To: , Qing Zhao In-Reply-To: <1C9277DB-4450-4484-A77A-F30BCBA0C628@oracle.com> (message from Qing Zhao on Wed, 15 Feb 2023 20:30:00 +0100) Subject: Sort-of ping for [PATCH] testsuite: Handle "packed" targets in c-c++-common/auto-init-7.c and -8.c MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20230215191957.F12532042E@pchp3.se.axis.com> <1C9277DB-4450-4484-A77A-F30BCBA0C628@oracle.com> Message-ID: <20230222175345.875752042C@pchp3.se.axis.com> Date: Wed, 22 Feb 2023 18:53:45 +0100 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Qing Zhao > Date: Wed, 15 Feb 2023 20:30:00 +0100 > Thank you for fixing this issue. Thanks! Although you're not holding an approver position I'm tempted to take that as approval, as you're the author of that test. This being a patch of no particular significance and having seen no other comments, I'll do that, but delay another week. brgds, H-P > > Qing > > > On Feb 15, 2023, at 2:19 PM, Hans-Peter Nilsson wrote: > > > > Tested for cris-elf. Ok to commit? > > > > -- >8 -- > > Looks like there's a failed assumption that > > sizeof (union U { char u1[5]; int u2; float u3; }) == 8. > > However, for "packed" targets like cris-elf, it's 5. > > > > These two tests have always failed for cris-elf. I see from > > https://gcc.gnu.org/pipermail/gcc-testresults/2023-February/777912.html > > that they fail on pru-elf too, but I don't know if the cause > > (and/or remedy) is the same. > > > > IMHO this is preferred over the alternative; splitting up > > that last line into two lines, like: > > /* { dg-final { scan-tree-dump "temp4 = \ > > .DEFERRED_INIT \\(8, 2, \&\"temp4\"" "gimple" { target { ! default_packed } } } } */ > > /* { dg-final { scan-tree-dump "temp4 = \ > > .DEFERRED_INIT \\(5, 2, \&\"temp4\"" "gimple" { target default_packed } } } */ > > > > gcc/testsuite: > > * c-c++-common/auto-init-7.c, c-c++-common/auto-init-8.c: Also > > match targets where sizeof (union U) == 5, like "packed" targets. > > --- > > gcc/testsuite/c-c++-common/auto-init-7.c | 2 +- > > gcc/testsuite/c-c++-common/auto-init-8.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/gcc/testsuite/c-c++-common/auto-init-7.c b/gcc/testsuite/c-c++-common/auto-init-7.c > > index b44dd5e68ed1..dd48d691596f 100644 > > --- a/gcc/testsuite/c-c++-common/auto-init-7.c > > +++ b/gcc/testsuite/c-c++-common/auto-init-7.c > > @@ -32,4 +32,4 @@ double foo() > > /* { dg-final { scan-tree-dump "temp1 = .DEFERRED_INIT \\(12, 2, \&\"temp1\"" "gimple" } } */ > > /* { dg-final { scan-tree-dump "temp2 = .DEFERRED_INIT \\(24, 2, \&\"temp2\"" "gimple" } } */ > > /* { dg-final { scan-tree-dump "temp3 = .DEFERRED_INIT \\(28, 2, \&\"temp3\"" "gimple" } } */ > > -/* { dg-final { scan-tree-dump "temp4 = .DEFERRED_INIT \\(8, 2, \&\"temp4\"" "gimple" } } */ > > +/* { dg-final { scan-tree-dump "temp4 = .DEFERRED_INIT \\((8|5), 2, \&\"temp4\"" "gimple" } } */ > > diff --git a/gcc/testsuite/c-c++-common/auto-init-8.c b/gcc/testsuite/c-c++-common/auto-init-8.c > > index 739ac0289315..863f2ba87d7d 100644 > > --- a/gcc/testsuite/c-c++-common/auto-init-8.c > > +++ b/gcc/testsuite/c-c++-common/auto-init-8.c > > @@ -32,4 +32,4 @@ double foo() > > /* { dg-final { scan-tree-dump "temp1 = .DEFERRED_INIT \\(12, 1, \&\"temp1\"" "gimple" } } */ > > /* { dg-final { scan-tree-dump "temp2 = .DEFERRED_INIT \\(24, 1, \&\"temp2\"" "gimple" } } */ > > /* { dg-final { scan-tree-dump "temp3 = .DEFERRED_INIT \\(28, 1, \&\"temp3\"" "gimple" } } */ > > -/* { dg-final { scan-tree-dump "temp4 = .DEFERRED_INIT \\(8, 1, \&\"temp4\"" "gimple" } } */ > > +/* { dg-final { scan-tree-dump "temp4 = .DEFERRED_INIT \\((8|5), 1, \&\"temp4\"" "gimple" } } */ > > -- > > 2.30.2 > > >