From: Segher Boessenkool <segher@kernel.crashing.org>
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: "'Jakub Jelinek'" <jakub@redhat.com>,
"'Jeff Law'" <jeffreyalaw@gmail.com>,
"'GCC Patches'" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix RTL simplifications of FFS, POPCOUNT and PARITY.
Date: Mon, 27 Feb 2023 10:47:34 -0600 [thread overview]
Message-ID: <20230227164734.GZ25951@gate.crashing.org> (raw)
In-Reply-To: <010401d949e3$bca11f20$35e35d60$@nextmovesoftware.com>
Hi!
On Sun, Feb 26, 2023 at 01:10:41PM -0000, Roger Sayle wrote:
> This patch teaches simplify-rtx.cc to err on the side of caution, by never
> creating (new) FFS, POPCOUNT or PARITY rtx with mismatched modes,
> matching the documentation.
> * simplify-rtx.cc (simplify_unary_operation_1) <case FFS>:
> Avoid generating FFS with mismatched operand and result modes,
Please have at least one word after a colon, so that it doesn't look
like something is missing. Changelog lines are 80 positions long :-)
The patch is okay for trunk. Thank you!
Segher
prev parent reply other threads:[~2023-02-27 16:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-01 15:55 Roger Sayle
2023-01-01 21:03 ` Segher Boessenkool
2023-01-01 22:59 ` roger
2023-01-02 15:45 ` Jeff Law
2023-01-02 15:59 ` Jakub Jelinek
2023-01-02 16:20 ` Jeff Law
2023-01-02 17:22 ` Jakub Jelinek
2023-01-02 17:38 ` Jeff Law
2023-01-03 11:33 ` Segher Boessenkool
2023-01-02 17:30 ` roger
2023-01-02 17:47 ` Jeff Law
2023-02-21 15:39 ` Jakub Jelinek
2023-02-26 13:10 ` Roger Sayle
2023-02-27 16:47 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227164734.GZ25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jeffreyalaw@gmail.com \
--cc=roger@nextmovesoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).