From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id 7DC313858D33; Wed, 1 Mar 2023 23:52:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7DC313858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x529.google.com with SMTP id o15so58377213edr.13; Wed, 01 Mar 2023 15:52:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=1chvDK4W5a5iFerWMHBJO+q0gQjw7agDyYe7k2hPbwM=; b=B1r2gwe+esci9iUBpZXNtCgTY61gZPRMB285gGuK1KMr+mRLtPrp5N2ey42I1pUbJX DK8/NF+ORmWNciNWZbEVuVFz+ZFdU/2IFQ3S6uYvW1M+KxYiF5MkmIeNLOzh7dBDvRkq 5usDsTjD7bb7gzZt0bIlLxZAD/M9mFkzsTxTutkF8HE46Zm7LkFLdThQG3g+d/pkXdk/ NhhU2Ftu7rPaAxoYup9QYiZRsuVp8mogYhgnVJo1nkuNTP7IjjXNae9rT64GfNaq3NgE uwiRA5MCSPHtVDjfvYSvccsAN91NNomI0KBlxlBaxkixuJwrr9r8DSSayLKfr5K4v6n4 0RMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1chvDK4W5a5iFerWMHBJO+q0gQjw7agDyYe7k2hPbwM=; b=DHvhNW4p/agRbbUZ9pFfkMTCektd5RlcS1OOu2AOr+97POcYLnOXmoBAuLILAiffl/ e2Ukxco6ZpXRp01xxnd6htFwRwU+h+RDC30TToWknrTdDFGSt6gnI88L0zKvkIJ9wFSO 2CthE0OchoYxDIM0u1Jt2s+P88RYFM8utZHOF3aqlB2JwDDLPSYnOg26okx0q3K4ZNjV V7HbfupBOjWOymMmSzieAW0kNBquoIQ7/QFs8hmEsQzExtATeNZmEvQfyswvNPGaJj7T YceV2727h4jeUpo3Y7PKc7erDZ0tVQgp3pR3oT1uU5lQY6uaHzmLUNS8BWeBoKVcEvkR m5nw== X-Gm-Message-State: AO0yUKVxT26dScF77dl53ddLH8irMbkJ2VHS7RG75faGDsIHW2y+nLOq WfQKKdTuEcQMiGUOV0W6lLo= X-Google-Smtp-Source: AK7set8E4qKjWb2hjuE9kOTvUxBLpzUesA1/0gUU4ufUAQYfQpZjUTwBjkwSgE2SzY1Q1+f+AjeurA== X-Received: by 2002:a17:906:660e:b0:8ae:f73e:233f with SMTP id b14-20020a170906660e00b008aef73e233fmr8583105ejp.32.1677714745032; Wed, 01 Mar 2023 15:52:25 -0800 (PST) Received: from nbbrfq (80-110-214-113.static.upcbusiness.at. [80.110.214.113]) by smtp.gmail.com with ESMTPSA id gq23-20020a170906e25700b008e40853a712sm6405206ejb.97.2023.03.01.15.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 15:52:24 -0800 (PST) Date: Thu, 2 Mar 2023 00:52:21 +0100 From: Bernhard Reutner-Fischer To: Andrew Pinski Cc: rep.dot.nop@gmail.com, gcc-patches@gcc.gnu.org, ian@airs.com, charlet@adacore.com, fortran@gcc.gnu.org Subject: Re: [PATCH][stage1] Remove conditionals around free() Message-ID: <20230302005221.01a373d3@nbbrfq> In-Reply-To: References: <20230301222856.12300c64@nbbrfq> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 1 Mar 2023 14:59:44 -0800 Andrew Pinski wrote: > On Wed, Mar 1, 2023 at 1:31=E2=80=AFPM Bernhard Reutner-Fischer via Fortr= an > wrote: > > > > Hi! > > > > Mere cosmetics. > > > > - if (foo !=3D NULL) > > free (foo); > > > > With the caveat that coccinelle ruins replacement whitespace or i'm > > uneducated enough to be unable to _not_ run the diff through > > sed -e 's/^+\([[:space:]]*\)free(/+\1free (/' > > at least. If anybody knows how to improve replacement whitespace, > > i'd be interrested but didn't look nor ask. ISTM that leading > > whitespace is somewhat ruined, too, so beware (8 spaces versus tab as > > far as i have spot-checked). > > > > Would touch > > gcc/ada/rtinit.c | 3 +-- =20 >=20 >=20 It's funny how you apparently did not comment that hunk in the end ;) > > intl/bindtextdom.c | 3 +-- > > intl/loadmsgcat.c | 6 ++---- > > intl/localcharset.c | 3 +-- =20 >=20 > intl is imported from glibc, though I don't know we have updated it in > recent years from glibc. i don't think we did, overdue, as we (probably) all know. OTOH i'm thankful that we don't have submodules but a plain, manageable repo. Of course that comes with a burden, which is nil if ignored throughout. Doesn't always pay out too well longterm if nobody (voluntarily) is in due charge. > > zlib/contrib/minizip/unzip.c | 2 +- > > zlib/contrib/minizip/zip.c | 2 +- > > zlib/examples/enough.c | 6 ++---- > > zlib/examples/gun.c | 2 +- > > zlib/examples/gzjoin.c | 3 +-- > > zlib/examples/gzlog.c | 6 ++---- =20 >=20 > zlib is definitely imported from zlib upstream. > So it might be good to check if we could import a new version and see > if it still works instead. =46rom a meta POV, i wonder where the trailing space in the subject comes from, looking at e.g.: https://gcc.gnu.org/pipermail/gcc-patches/2023-March/date.html#613110 I think and hope that the newer(?) ones by https://inbox.sourceware.org/gcc-patches/?t=3Dxyz do not exhibit these invented trailing blanks nobody ever wrote for real, does it. Thanks for reminding me of intl and it's outdatedness, although i certainly don't have ambition to do anything about it for sure. I didn't care 15 or 20 years ago and nowadays i'd call that attitude a tradition, at least ATM ;) TBH i initially had only considered gcc/ but somehow found that unfair. Great idea that inclusion was. thanks, > > 4) i most likely will not remember to split it apart and send proper > > patches, tested patches, in stage 1 to maintainers proper, so if > > anyone feels like pursuing this, be my guest. I thought i'd just > > mention it. > > > > cheers, =20