From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by sourceware.org (Postfix) with ESMTPS id 4CE463858D33 for ; Thu, 2 Mar 2023 00:59:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CE463858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1677718741; x=1709254741; h=from:to:cc:in-reply-to:subject:mime-version: content-transfer-encoding:references:message-id:date; bh=eMuMsd0EsbfZg03Ad/ci5EoXBbNMwiEDZjSPQl2vfP4=; b=l7UFOxNgZAjemWaD5+vWwfhFfAWj/ZCNwwK2jvIFnMe+gJrdNQdZ0CZf 6pzFXG5VBkEidXGUDs/C9mXXHwCMv4it6plXcprc9B2YZ8FN7ihC9oGlI lVxOa6dSQG5ZcCOhnxYtLvTCp0KtDgB6THNhQR6f0Dmm25NMKtMHQq6Um 1AoLCUuxFRVPW/QuPXGihuztj1ua/qRNSfOWVoolyraKouwfd5vTl0DSz vxgqvDKPI/XoHx8x2XcKG/7/A09Trm/ET0/LnnqA4S3WwZBYg6jThlkr1 x1oWPDts0TZ0lcFJ3ngWKcZbH3lkqZMV8azT3SiWVE/lc387XgqH2T+BL Q==; From: Hans-Peter Nilsson To: Bernhard Reutner-Fischer CC: , , In-Reply-To: <20230302013712.59a001bd@nbbrfq> (message from Bernhard Reutner-Fischer on Thu, 2 Mar 2023 01:37:12 +0100) Subject: Re: [PATCH 1/2] testsuite: Fix analyzer errors for newlib-errno MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20230228184735.24E6E20438@pchp3.se.axis.com> <6bc39adefb2af674338a73408f75733b36ccbe0b.camel@redhat.com> <20230301005937.632A42042E@pchp3.se.axis.com> <9bc0171b3a54d691324cdaf202f5b1aae0829e7d.camel@redhat.com> <20230301030123.A0A2B20438@pchp3.se.axis.com> <20230301153646.9FF6220426@pchp3.se.axis.com> <20230301160231.CFBA82040C@pchp3.se.axis.com> <20230302002336.6498edab@nbbrfq> <20230301235433.EE3D220426@pchp3.se.axis.com> <20230302013712.59a001bd@nbbrfq> Message-ID: <20230302005857.B6C6F2040C@pchp3.se.axis.com> Date: Thu, 2 Mar 2023 01:58:57 +0100 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Thu, 2 Mar 2023 01:37:12 +0100 > From: Bernhard Reutner-Fischer > On Thu, 2 Mar 2023 00:54:33 +0100 > Hans-Peter Nilsson wrote: > > > > Date: Thu, 2 Mar 2023 00:23:36 +0100 > > > From: Bernhard Reutner-Fischer > > > > > On Wed, 1 Mar 2023 17:02:31 +0100 > > > Hans-Peter Nilsson via Gcc-patches wrote: > > > > > > > > From: Hans-Peter Nilsson > > > > > Date: Wed, 1 Mar 2023 16:36:46 +0100 > > > > > > > > > ... this is what I intend to commit later > > > > > today, just keeping the added comment as brief as > > > > > reasonable: > > > > > > > > Except I see the hook for errno magic took care of > > > > gcc.dg/analyzer/flex-without-call-summaries.c so I'll add > > > > that to the list of handled "FAIL"s in the commit log. Yay. > > > > > > But in the end it means we'll have to keep _[_]+errno{,_location} 'til > > > we bump requirements or 10, 20 years or the end of the universe, > > > doesn't it. > > > Way fancy. > > > > Not sure I see your point? The (other) identifiers are already there. > > I'm certainly not opposed to this partiular identifier, no. > > > > > (And you do realize that this is in the analyzer part of gcc, right?) > > And yes, i'm well aware this is "just" the analyzer -- which is unfair > to state like that and does not mean to imply any inferiority -- > particular in this spot. (Your statement and values; it can be read as you putting that as mine, which I hope was not intended.) My point is that the presence of those identifiers does not affects an ABI or code-generating parts of gcc. All the identifiers are present for all targets - for all invocation of the analyzer. If that passes a nuisance threshold, it seems it can be changed easily, say by moving it to a target-hook by someone who cares deeply enough. > Just let's ditch any specialcased identifier which was superseded > reliably ASAP? I'm certainly not opposed to *that* brgds, H-P