public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: rep.dot.nop@gmail.com, HAO CHEN GUI <guihaoc@linux.ibm.com>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
	fortran <fortran@gcc.gnu.org>,
	Segher Boessenkool <segher@kernel.crashing.org>,
	David <dje.gcc@gmail.com>, "Kewen.Lin" <linkw@linux.ibm.com>,
	Peter Bergner <bergner@linux.ibm.com>
Subject: Re: [PATCH, gfortran] Escalate failure when Hollerith constant to real conversion fails [PR103628]
Date: Thu, 2 Mar 2023 01:00:22 +0100	[thread overview]
Message-ID: <20230302010022.1684dbaa@nbbrfq> (raw)
In-Reply-To: <c82181f1-333b-efc4-e297-2666866e8003@codesourcery.com>

On Wed, 1 Mar 2023 10:40:15 +0100
Tobias Burnus <tobias@codesourcery.com> wrote:

> Hi,
> 
> Please CC fortran@gcc for Fortran patches.

> > --- a/gcc/fortran/target-memory.cc
> > +++ b/gcc/fortran/target-memory.cc
> > @@ -417,10 +417,13 @@ gfc_interpret_float (int kind, unsigned char *buffer, size_t buffer_size,
> >   {
> >     gfc_set_model_kind (kind);
> >     mpfr_init (real);
> > -  gfc_conv_tree_to_mpfr (real,
> > -                      native_interpret_expr (gfc_get_real_type (kind),
> > -                                             buffer, buffer_size));
> >
> > +  tree source  = native_interpret_expr (gfc_get_real_type (kind), buffer,

s/source  = native/source = native/

additionally to moving mpfr_init around and the other comments.
Please send an updated, regtested patch?
thanks && cheers,

  parent reply	other threads:[~2023-03-02  0:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01  7:09 HAO CHEN GUI
2023-03-01  9:40 ` Tobias Burnus
2023-03-01 15:39   ` Steve Kargl
2023-03-02  0:07     ` Bernhard Reutner-Fischer
2023-03-02  1:10       ` Steve Kargl
2023-03-02  0:00   ` Bernhard Reutner-Fischer [this message]
2023-03-02  2:27 ` Kewen.Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230302010022.1684dbaa@nbbrfq \
    --to=rep.dot.nop@gmail.com \
    --cc=bergner@linux.ibm.com \
    --cc=dje.gcc@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=guihaoc@linux.ibm.com \
    --cc=linkw@linux.ibm.com \
    --cc=segher@kernel.crashing.org \
    --cc=tobias@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).