From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by sourceware.org (Postfix) with ESMTPS id DE3033858D33 for ; Thu, 2 Mar 2023 01:20:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE3033858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1677720006; x=1709256006; h=from:to:subject:mime-version:content-transfer-encoding: message-id:date; bh=cmFZa9rPW6czv6IUW+P1PKY6vPals+SZL3uozLNLo/I=; b=gk6l9Uu6InovuHH9Ohexj2cemyXsfbobqa1eGUjHWQVHvSl913yA5xP0 byR7OjHKPlpL3rHmEjF7qLBwXTV7m/GjETErGLVeqak3c0MFt9iUZlGbb ygR40XPL5Cu9yBE50ePc7hgI6fH4XuTLg3outghRfiKIaZzd7GpmMY0Dv u5k4g62rxJ//JmuYpvLMpa/tr76EkbkBbC8XGpVNebHU7HdFDR6InZuNX Qlqz20XVunYdPqebkXQ9dgGgO1N/2AviFC62B7eukARoioA3OjksVqw4H 8aVAH8BpWfDuwSZ5+x79Ao1v3MVNJTJXHeGvrJ/1z0hvN2RQe118imHLX A==; From: Hans-Peter Nilsson To: Subject: [COMMITTED] testsuite: Fix gcc.dg/attr-copy-6.c for user-label-prefixed targets MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Message-ID: <20230302012003.6A0D52040C@pchp3.se.axis.com> Date: Thu, 2 Mar 2023 02:20:03 +0100 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Trivia: I copied that ASMNAME construct from the 18-year-minus-a-month old commit of r0-66993-gc5221531453e02, where it fixed a similar testsuite error. Committed as obvious. -- >8 -- This fixes: Running /x/gcc/testsuite/gcc.dg/dg.exp ... ... FAIL: gcc.dg/attr-copy-6.c (test for excess errors) for cris-elf, where gcc.log has: Excess errors: /x/gcc/testsuite/gcc.dg/attr-copy-6.c:91:3: error: 'fnoreturn_alias' aliased to undefined symbol 'fnoreturn_name' Asm-declared identifiers need to prepend __USER_LABEL_PREFIX__ to the asm-name, something which is often overlooked because it's empty for most targets. N.B: attribute-alias does not need the same treatment. The identical construct added here, is in several tests. * gcc.dg/attr-copy-6.c: Prefix asm-declared name with __USER_LABEL_PREFIX__. --- gcc/testsuite/gcc.dg/attr-copy-6.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/attr-copy-6.c b/gcc/testsuite/gcc.dg/attr-copy-6.c index cf578bddb1b0..30a1317bf928 100644 --- a/gcc/testsuite/gcc.dg/attr-copy-6.c +++ b/gcc/testsuite/gcc.dg/attr-copy-6.c @@ -9,6 +9,10 @@ #define ATTR(...) __attribute__ ((__VA_ARGS__)) #define ASRT(expr) _Static_assert (expr, #expr) +#define ASMNAME(cname) ASMNAME2 (__USER_LABEL_PREFIX__, cname) +#define ASMNAME2(prefix, cname) STRING (prefix) cname +#define STRING(x) #x + /* Variable that is local to this translation unit but that can be modified from other units by calling reset_unit_local(). */ static int unit_local; @@ -79,7 +83,7 @@ extern _Noreturn void fnoreturn (void); extern __typeof (fnoreturn) ATTR (visibility ("hidden")) - fnoreturn __asm__ ("fnoreturn_name"); + fnoreturn __asm__ (ASMNAME ("fnoreturn_name")); void fnoreturn (void) { -- 2.30.2