public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@axis.com>
To: Mike Stump <mikestump@comcast.net>
Cc: <gcc-patches@gcc.gnu.org>, <mliska@suse.cz>
Subject: Re: Ping: [PATCH 1/2] testsuite: Provide means to regexp in multiline patterns
Date: Tue, 7 Mar 2023 01:32:13 +0100	[thread overview]
Message-ID: <20230307003213.B90CC20405@pchp3.se.axis.com> (raw)
In-Reply-To: <CBF536D0-E41F-422F-946C-3D263A7F3E75@comcast.net> (message from Mike Stump on Mon, 6 Mar 2023 02:05:35 -0800)

> From: Mike Stump <mikestump@comcast.net>
> Date: Mon, 6 Mar 2023 02:05:35 -0800

> Ok

Thanks!  The server-side hook didn't like my ChangeLog
entry:

            * lib/multiline.exp (_build_multiline_regex): Map
            "{re:" to "(", ":re}" to ")" and ":re?}" to ")?".

It seems I forgot to validate that patch by
contrib/gcc-changelog/git_check_commit.py, which complains:

Checking c0debd6f586ef76f1ceabfed11d7eaf8f6d1b110: FAILED
ERR: bad wrapping of parenthesis: "	"{re:" to "(", ":re}" to ")" and ":re?}" to ")?"."

I gave in and took the easy way out; not fixing the bug in
that script, but instead "wrapped the parenthesis" to:

	* lib/multiline.exp (_build_multiline_regex): Map
	"{re:" to "(", similarly ")?" from ":re?}" and the
	same without question mark.

I hope to make amends by fixing git_check_commit.py, if
given guidance.

brgds, H-P

  reply	other threads:[~2023-03-07  0:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24 19:16 Hans-Peter Nilsson
2023-03-04  1:58 ` Ping: " Hans-Peter Nilsson
2023-03-06 10:05   ` Mike Stump
2023-03-07  0:32     ` Hans-Peter Nilsson [this message]
2023-03-07 14:34       ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230307003213.B90CC20405@pchp3.se.axis.com \
    --to=hp@axis.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mikestump@comcast.net \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).