From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3C5AC3858289 for ; Wed, 8 Mar 2023 15:53:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3C5AC3858289 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678290798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y31FiglGowuTapLicp2+rV/Qx7pdnoZNkhvafPZYNDA=; b=BxPAFzqKdKUDB8VaNvnuHYRrj5tA0gtIXj1U/azn9BqAEqRKFB36YZ0lAoKtsOtWyxXkWq ct/NnZzZlxElhRD69CbnPbAl0f+mq+vc56079HHbA+PBeqFzayecErTUqDRDwVr8PrPToV VKEnqptyTJiFrBspBrWF7Q7GzIKSGTQ= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-vIk_wBehPw6KmEOc0WYAJQ-1; Wed, 08 Mar 2023 10:53:17 -0500 X-MC-Unique: vIk_wBehPw6KmEOc0WYAJQ-1 Received: by mail-qv1-f71.google.com with SMTP id l13-20020ad44d0d000000b004c74bbb0affso9417883qvl.21 for ; Wed, 08 Mar 2023 07:53:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678290796; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y31FiglGowuTapLicp2+rV/Qx7pdnoZNkhvafPZYNDA=; b=vbySNCkDN6avkvnYzuZ+6nYWDfXlTEuZdoBEFpAbZaH+cP2Eeme5qkCga+U2vCfODl VBEdvWb3EKKsTvTIQuK5cIjSoHFTGpOAUIMiXRupgleqn8TpOTlhE9nPVl930QyGf2Gi CxTaNkFcyQmymZqWD0VDbAfcZ5c/WV4SWR8BzPvPITOEa9LDdfkwreqaioPuUhUYl38a 70jLxf+J4GPZvVATX7UXCI262Ou+5ohnDkJNREuJZW1Zix90JzB3l9lG1rsUSb+gL75L FNvESSlgRx8+Vy9N9WGwkj587CHwKBSocGDqYXgkT3ASgkryscxB8GHJk9B7A1bUB6iM ELFA== X-Gm-Message-State: AO0yUKWjxlGlU5YTmHSJ0dYLMGVpQS2ZB8ZNQ6FnewEhNkctLk1kjVlC YjzaQqq/LwKjfH5UKKMwggdzzupNuCtu+ar9acxBQvz/jJbOKokwVFp8l7E4I3FBIK2AvMzXxn1 AsdILv1XTACKHKsSR0snmcPcB4O6aeJmIoB+pjAPiWfW0GcM/6C+buB0/mKYF6At6Bs639pvjo7 A= X-Received: by 2002:a05:6214:1cc8:b0:572:5a3a:f55 with SMTP id g8-20020a0562141cc800b005725a3a0f55mr28481578qvd.33.1678290796481; Wed, 08 Mar 2023 07:53:16 -0800 (PST) X-Google-Smtp-Source: AK7set9GQqLmLE3f8fL5cv1R+hqL1gmhdYozbPoHZzQw2FY+bVJVGQ1ajaoot4IaUmPZulcLCqO7DA== X-Received: by 2002:a05:6214:1cc8:b0:572:5a3a:f55 with SMTP id g8-20020a0562141cc800b005725a3a0f55mr28481539qvd.33.1678290796087; Wed, 08 Mar 2023 07:53:16 -0800 (PST) Received: from localhost.localdomain (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id s133-20020a37a98b000000b00729b7d71ac7sm11611542qke.33.2023.03.08.07.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 07:53:15 -0800 (PST) From: Patrick Palka To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Patrick Palka Subject: [PATCH] libstdc++: Implement LWG 3715 changes to view_interface::empty Date: Wed, 8 Mar 2023 10:53:06 -0500 Message-Id: <20230308155306.257241-1-ppalka@redhat.com> X-Mailer: git-send-email 2.40.0.rc0.57.g454dfcbddf MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tested on x86_64-pc-linux-gnu, does this look OK for trunk? libstdc++-v3/ChangeLog: * include/bits/ranges_util.h (view_interface::empty): Add preferred overloads that use ranges::size when the range is sized as per LWG 3715. * testsuite/std/ranges/adaptors/lwg3715.cc: New test. --- libstdc++-v3/include/bits/ranges_util.h | 16 +++++++-- .../testsuite/std/ranges/adaptors/lwg3715.cc | 33 +++++++++++++++++++ 2 files changed, 47 insertions(+), 2 deletions(-) create mode 100644 libstdc++-v3/testsuite/std/ranges/adaptors/lwg3715.cc diff --git a/libstdc++-v3/include/bits/ranges_util.h b/libstdc++-v3/include/bits/ranges_util.h index e4643e31a20..880a0ce0143 100644 --- a/libstdc++-v3/include/bits/ranges_util.h +++ b/libstdc++-v3/include/bits/ranges_util.h @@ -97,15 +97,27 @@ namespace ranges constexpr bool empty() noexcept(noexcept(_S_empty(_M_derived()))) - requires forward_range<_Derived> + requires forward_range<_Derived> && (!sized_range<_Derived>) { return _S_empty(_M_derived()); } + constexpr bool + empty() + noexcept(noexcept(ranges::size(_M_derived()) == 0)) + requires sized_range<_Derived> + { return ranges::size(_M_derived()) == 0; } + constexpr bool empty() const noexcept(noexcept(_S_empty(_M_derived()))) - requires forward_range + requires forward_range && (!sized_range) { return _S_empty(_M_derived()); } + constexpr bool + empty() const + noexcept(noexcept(ranges::size(_M_derived()) == 0)) + requires sized_range + { return ranges::size(_M_derived()) == 0; } + constexpr explicit operator bool() noexcept(noexcept(ranges::empty(_M_derived()))) requires requires { ranges::empty(_M_derived()); } diff --git a/libstdc++-v3/testsuite/std/ranges/adaptors/lwg3715.cc b/libstdc++-v3/testsuite/std/ranges/adaptors/lwg3715.cc new file mode 100644 index 00000000000..96ee7087be0 --- /dev/null +++ b/libstdc++-v3/testsuite/std/ranges/adaptors/lwg3715.cc @@ -0,0 +1,33 @@ +// { dg-options "-std=gnu++23" } +// { dg-do run { target c++23 } } + +// Verify LWG 3715 changes. + +#include +#include +#include + +void +test01() +{ + std::istringstream ints("0 1 2 3 4"); + auto i = std::views::istream(ints); + auto r4 = std::views::counted(i.begin(), 4) | std::views::chunk(2); + VERIFY( !r4.empty() ); +} + +void +test02() +{ + std::istringstream ints("0 1 2 3 4"); + auto i = std::views::istream(ints); + auto r0 = std::views::counted(i.begin(), 0) | std::views::chunk(2); + VERIFY( r0.empty() ); +} + +int +main() +{ + test01(); + test02(); +} -- 2.40.0.rc0.57.g454dfcbddf