From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id E3B413858D20 for ; Thu, 9 Mar 2023 22:17:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E3B413858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 329MGM1X008277; Thu, 9 Mar 2023 16:16:22 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 329MGLNE008272; Thu, 9 Mar 2023 16:16:21 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 9 Mar 2023 16:16:21 -0600 From: Segher Boessenkool To: Michael Meissner , gcc-patches@gcc.gnu.org, "Kewen.Lin" , David Edelsohn , Peter Bergner , Will Schmidt Subject: Re: [PATCH 2/2] Rework 128-bit complex multiply and divide. Message-ID: <20230309221621.GV25951@gate.crashing.org> References: <20230303213544.GJ25951@gate.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Mar 09, 2023 at 11:11:34AM -0500, Michael Meissner wrote: > On Fri, Mar 03, 2023 at 03:35:44PM -0600, Segher Boessenkool wrote: > > > +/* { dg-final { scan-assembler "bl __divtc3" } } */ > > > > This name depends on what object format and ABI is in use (some have an > > extra leading underscore, or a dot, or whatever). > > Yes it is needed if GCC is configured against an older GLIBC before the full > IEEE 128-bit support was added. For example, on my big endian test system, you > get warnings if you switch the floating point format. I would imagine it would > also fail on little endian system with older libraries. The regexp is not good enough, that is all. Maybe {bl .?__divtc3} or similar? We have many examples in the tests already. Segher