From: Marek Polacek <polacek@redhat.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>, Jason Merrill <jason@redhat.com>
Subject: [PATCH] c++: suppress -Wdangling-reference for std::span [PR107532]
Date: Fri, 10 Mar 2023 14:07:41 -0500 [thread overview]
Message-ID: <20230310190741.168444-1-polacek@redhat.com> (raw)
std::span is a view and therefore should be treated as a reference
wrapper class for the purposes of -Wdangling-reference. I'm not sure
there's a pattern that we could check for.
Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk?
PR c++/107532
gcc/cp/ChangeLog:
* call.cc (reference_like_class_p): Check for std::span.
gcc/testsuite/ChangeLog:
* g++.dg/warn/Wdangling-reference10.C: New test.
---
gcc/cp/call.cc | 1 +
gcc/testsuite/g++.dg/warn/Wdangling-reference10.C | 12 ++++++++++++
2 files changed, 13 insertions(+)
create mode 100644 gcc/testsuite/g++.dg/warn/Wdangling-reference10.C
diff --git a/gcc/cp/call.cc b/gcc/cp/call.cc
index 3dfa12a0733..c01e7b82457 100644
--- a/gcc/cp/call.cc
+++ b/gcc/cp/call.cc
@@ -13800,6 +13800,7 @@ reference_like_class_p (tree ctype)
tree name = DECL_NAME (tdecl);
return (name
&& (id_equal (name, "reference_wrapper")
+ || id_equal (name, "span")
|| id_equal (name, "ref_view")));
}
for (tree fields = TYPE_FIELDS (ctype);
diff --git a/gcc/testsuite/g++.dg/warn/Wdangling-reference10.C b/gcc/testsuite/g++.dg/warn/Wdangling-reference10.C
new file mode 100644
index 00000000000..733fb8cce63
--- /dev/null
+++ b/gcc/testsuite/g++.dg/warn/Wdangling-reference10.C
@@ -0,0 +1,12 @@
+// PR c++/107532
+// { dg-do compile { target c++20 } }
+// { dg-options "-Wdangling-reference" }
+
+#include <span>
+#include <vector>
+
+void f(const std::vector<int>& v)
+{
+ const int& r = std::span<const int>(v)[0]; // { dg-bogus "dangling reference" }
+ (void) r;
+}
base-commit: 20d790aa3ea5b0d240032cab997b8e0938cac62c
--
2.39.2
next reply other threads:[~2023-03-10 19:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 19:07 Marek Polacek [this message]
2023-03-13 15:18 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310190741.168444-1-polacek@redhat.com \
--to=polacek@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).