From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id A8C5F3857C4F; Wed, 15 Mar 2023 21:11:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A8C5F3857C4F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x536.google.com with SMTP id cn21so50531705edb.0; Wed, 15 Mar 2023 14:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678914662; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xqdQ1EdULR3ZC6fkrSXsjHukjP0LeO2HJ2lKdg8Fd9E=; b=c+tjO4EL0wGQ2wt42At4DxolRGIM6EdnNyKIYCPX2tITxIxSbqL5LUuJZxTPLybh7N VATlCgni22G7spKCYBTkLLcPewS4PcGuehcIQ0p3PmJzsxIKAfrm8YfNMp21ODD3rvrS lddFBX1Bes2NwHkyQZZnftYtNz11TFYFKi88E1/gWMQXJJQHSactD0epvDg8OzzyEpX8 1F14XP2/bl5atG9g28oT9y5cQsCDXmpTeuyu1mjgTUWHI6OfoxZladym9ULgMDA1hBA/ +RyLdeYRGYQbVM0zsH3Tk3yvOyeREwD4rdJdwTCavXkRmUzj+aofjSTz6k2g+q/h4jr+ cPPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678914662; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xqdQ1EdULR3ZC6fkrSXsjHukjP0LeO2HJ2lKdg8Fd9E=; b=IhVbJ+5wOWYb49bCK14k8HdMusXBIP0taUoD/8C5jcG3+7JFfIdYfaUIb5HfeFXx2w SZfAslXMRkyalIp7kjycEH5Os1PSw7byi/6d0TJkCusSkWT4obcB3Y/C2JrUxXm2eKt0 NFozxhJLg/a7o+/Yu15t06e1z2jd8IU1KG1BYVa0bnwHupG+EcH8u2MVnbn78h5nHReS icNsQW1sY/HS/972sh2D2EIVC4uCP3HjuayY5RP1zz3ZqokpBG6fHfetp3h+SopgvxP/ cAQZM3DT/sGY+bWYu7r4ocGmAhxRGmbrrgFWcx2kA0Tfy7D3jRTfeMC9Z/n19OCCJmPQ IzRg== X-Gm-Message-State: AO0yUKUlcchRdIUEzv1h+wYrXQRzxi8B0IfsANIr9rd6AzNTysbzQJnO u0EYfatyzN4Cfdt2IHJuWXMBahJihrsGJWKZ X-Google-Smtp-Source: AK7set/MLjSfWtSAN5EHgw17S1t1LmCHNfg+dydixQWLfUT1VTVvZnTkVeg8bWady9QzNbuAWH6vlg== X-Received: by 2002:a17:906:f193:b0:8b0:f59e:ab1b with SMTP id gs19-20020a170906f19300b008b0f59eab1bmr7424121ejb.75.1678914661782; Wed, 15 Mar 2023 14:11:01 -0700 (PDT) Received: from 192.168.1.35 ([188.119.40.52]) by smtp.gmail.com with ESMTPSA id qw12-20020a1709066a0c00b008d606b1bbb1sm2988637ejc.9.2023.03.15.14.11.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 14:11:01 -0700 (PDT) From: Berke Yavas To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Cc: Berke Yavas Subject: [PATCH] c++, libstdc++: new compiler built in is_scalar, use built-in is_scalar in libstdc++ std::is_scalar Date: Thu, 16 Mar 2023 00:10:12 +0300 Message-Id: <20230315211011.2023906-1-iamberkeyavas@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Have implemented a new compiler built-in for the scalar types(is_scalar). Changed the libstdc++ std::is_scalar implementation to use this new compiler built_in when available. tested on x86_64-redhat-linux. Compared test results and configured with --enable-bootstrap gcc/cp/ChangeLog: * constraint.cc (diagnose_trait_expr): Add note for CPTK_IS_SCALAR failing. * cp-trait.def (IS_SCALAR): Define IS_SCALAR trait. * cxx-pretty-print.cc (pp_cxx_userdef_literal): Add __is_scalar to comment. * parser.cc (cp_parser_fold_expression): Likewise. * semantics.cc (trait_expr_value): Implement built-in CPTK_IS_SCALAR. (finish_trait_expr): Add CPTK_IS_SCALAR. libstdc++-v3/ChangeLog: * include/bits/cpp_type_traits.h (__is_scalar): Rename to __is_arith_or_ptr. * include/bits/stl_algobase.h (__fill_a1, __fill_n_a1): Adjust. * include/bits/valarray_array.h: Likewise.. * include/std/type_traits (is_scalar): Use built-in __is_scalar if available. gcc/testsuite/ChangeLog: * g++.dg/ext/has-builtin-1.C: Check __is_scalar. * g++.dg/tm/pr46567.C: Rename __is_scalar to __is_arith_or_ptr to avoid collision with built-in. * g++.dg/torture/pr57107.C: Likewise. * g++.dg/ext/is_scalar.C: New test. Signed-off-by: Berke Yavas --- gcc/cp/constraint.cc | 3 +++ gcc/cp/cp-trait.def | 1 + gcc/cp/cxx-pretty-print.cc | 3 ++- gcc/cp/parser.cc | 1 + gcc/cp/semantics.cc | 4 ++++ gcc/testsuite/g++.dg/ext/has-builtin-1.C | 4 ++++ gcc/testsuite/g++.dg/ext/is_scalar.C | 21 +++++++++++++++++++++ gcc/testsuite/g++.dg/tm/pr46567.C | 10 +++++----- gcc/testsuite/g++.dg/torture/pr57107.C | 4 ++-- libstdc++-v3/include/bits/cpp_type_traits.h | 4 ++-- libstdc++-v3/include/bits/stl_algobase.h | 8 ++++---- libstdc++-v3/include/bits/valarray_array.h | 2 +- libstdc++-v3/include/std/type_traits | 7 +++++++ 13 files changed, 57 insertions(+), 15 deletions(-) create mode 100644 gcc/testsuite/g++.dg/ext/is_scalar.C diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc index 9374327008b..f799ba2efd5 100644 --- a/gcc/cp/constraint.cc +++ b/gcc/cp/constraint.cc @@ -3747,6 +3747,9 @@ diagnose_trait_expr (tree expr, tree args) case CPTK_IS_UNION: inform (loc, " %qT is not a union", t1); break; + case CPTK_IS_SCALAR: + inform(loc, " %qT is not a scalar type", t1); + break; case CPTK_IS_AGGREGATE: inform (loc, " %qT is not an aggregate", t1); break; diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def index 823899a26c5..8dace289e88 100644 --- a/gcc/cp/cp-trait.def +++ b/gcc/cp/cp-trait.def @@ -82,6 +82,7 @@ DEFTRAIT_EXPR (IS_TRIVIALLY_ASSIGNABLE, "__is_trivially_assignable", 2) DEFTRAIT_EXPR (IS_TRIVIALLY_CONSTRUCTIBLE, "__is_trivially_constructible", -1) DEFTRAIT_EXPR (IS_TRIVIALLY_COPYABLE, "__is_trivially_copyable", 1) DEFTRAIT_EXPR (IS_UNION, "__is_union", 1) +DEFTRAIT_EXPR (IS_SCALAR, "__is_scalar", 1) DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, "__reference_constructs_from_temporary", 2) DEFTRAIT_EXPR (REF_CONVERTS_FROM_TEMPORARY, "__reference_converts_from_temporary", 2) diff --git a/gcc/cp/cxx-pretty-print.cc b/gcc/cp/cxx-pretty-print.cc index bea52a608f1..a79359430a5 100644 --- a/gcc/cp/cxx-pretty-print.cc +++ b/gcc/cp/cxx-pretty-print.cc @@ -437,7 +437,8 @@ pp_cxx_userdef_literal (cxx_pretty_printer *pp, tree t) __is_polymorphic ( type-id ) __is_std_layout ( type-id ) __is_trivial ( type-id ) - __is_union ( type-id ) */ + __is_union ( type-id ) + __is_scalar ( type-id ) */ void cxx_pretty_printer::primary_expression (tree t) diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc index b00a6cd5b8b..8465d4fbcdb 100644 --- a/gcc/cp/parser.cc +++ b/gcc/cp/parser.cc @@ -5577,6 +5577,7 @@ cp_parser_fold_expression (cp_parser *parser, tree expr1) __is_std_layout ( type-id ) __is_trivial ( type-id ) __is_union ( type-id ) + __is_scalar ( type-id ) Objective-C++ Extension: diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc index db982d594e6..81b13d1ae5c 100644 --- a/gcc/cp/semantics.cc +++ b/gcc/cp/semantics.cc @@ -12025,6 +12025,9 @@ trait_expr_value (cp_trait_kind kind, tree type1, tree type2) case CPTK_IS_UNION: return type_code1 == UNION_TYPE; + case CPTK_IS_SCALAR: + return SCALAR_TYPE_P (type1); + case CPTK_IS_ASSIGNABLE: return is_xible (MODIFY_EXPR, type1, type2); @@ -12190,6 +12193,7 @@ finish_trait_expr (location_t loc, cp_trait_kind kind, tree type1, tree type2) case CPTK_IS_CLASS: case CPTK_IS_ENUM: case CPTK_IS_UNION: + case CPTK_IS_SCALAR: case CPTK_IS_SAME: break; diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C index f343e153e56..4bf06a7a438 100644 --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C @@ -146,3 +146,7 @@ #if !__has_builtin (__remove_cvref) # error "__has_builtin (__remove_cvref) failed" #endif +#if !__has_builtin (__is_scalar) +# error "__has_builtin (__is_scalar) failed" +#endif + diff --git a/gcc/testsuite/g++.dg/ext/is_scalar.C b/gcc/testsuite/g++.dg/ext/is_scalar.C new file mode 100644 index 00000000000..1d58f6ec475 --- /dev/null +++ b/gcc/testsuite/g++.dg/ext/is_scalar.C @@ -0,0 +1,21 @@ +// { dg-do compile { target c++11 } } + +#define SA(X) static_assert((X),#X) + +struct S { int m; }; + +enum class E { + e +}; + +int main() { + char* pNull= nullptr; + + SA(__is_scalar(decltype(pNull))); + SA(__is_scalar(int)); + SA(__is_scalar(double)); + SA(__is_scalar(E)); + SA(__is_scalar(char const *)); + SA(!__is_scalar(struct S)); + return 0; +} \ No newline at end of file diff --git a/gcc/testsuite/g++.dg/tm/pr46567.C b/gcc/testsuite/g++.dg/tm/pr46567.C index 6d791484448..760c7fd6cab 100644 --- a/gcc/testsuite/g++.dg/tm/pr46567.C +++ b/gcc/testsuite/g++.dg/tm/pr46567.C @@ -225,7 +225,7 @@ namespace std __attribute__ ((__visibility__ ("default"))) { : public __traitor<__is_void<_Tp>, __is_arithmetic<_Tp> > { }; template - struct __is_scalar + struct __is_arith_or_ptr : public __traitor<__is_arithmetic<_Tp>, __is_pointer<_Tp> > { }; template @@ -1325,7 +1325,7 @@ namespace std __attribute__ ((__visibility__ ("default"))) { } template inline typename - __gnu_cxx::__enable_if::__value, void>::__type + __gnu_cxx::__enable_if::__value, void>::__type __fill_a(_ForwardIterator __first, _ForwardIterator __last, const _Tp& __value) { @@ -1334,7 +1334,7 @@ namespace std __attribute__ ((__visibility__ ("default"))) { } template inline typename - __gnu_cxx::__enable_if<__is_scalar<_Tp>::__value, void>::__type + __gnu_cxx::__enable_if<__is_arith_or_ptr<_Tp>::__value, void>::__type __fill_a(_ForwardIterator __first, _ForwardIterator __last, const _Tp& __value) { @@ -1362,7 +1362,7 @@ namespace std __attribute__ ((__visibility__ ("default"))) { } template inline typename - __gnu_cxx::__enable_if::__value, _OutputIterator>::__type + __gnu_cxx::__enable_if::__value, _OutputIterator>::__type __fill_n_a(_OutputIterator __first, _Size __n, const _Tp& __value) { for (; __n > 0; --__n, ++__first) @@ -1371,7 +1371,7 @@ namespace std __attribute__ ((__visibility__ ("default"))) { } template inline typename - __gnu_cxx::__enable_if<__is_scalar<_Tp>::__value, _OutputIterator>::__type + __gnu_cxx::__enable_if<__is_arith_or_ptr<_Tp>::__value, _OutputIterator>::__type __fill_n_a(_OutputIterator __first, _Size __n, const _Tp& __value) { const _Tp __tmp = __value; diff --git a/gcc/testsuite/g++.dg/torture/pr57107.C b/gcc/testsuite/g++.dg/torture/pr57107.C index 4dbd32bd298..42ec0c8d350 100644 --- a/gcc/testsuite/g++.dg/torture/pr57107.C +++ b/gcc/testsuite/g++.dg/torture/pr57107.C @@ -27,7 +27,7 @@ namespace std __attribute__ ((__visibility__ ("default"))) { }; template struct __is_arithmetic : public __traitor<__is_integer<_Tp>, __is_floating<_Tp> > { }; - template struct __is_scalar : public __traitor<__is_arithmetic<_Tp>, __is_pointer<_Tp> > { + template struct __is_arith_or_ptr : public __traitor<__is_arithmetic<_Tp>, __is_pointer<_Tp> > { }; } namespace __gnu_cxx __attribute__ ((__visibility__ ("default"))) { @@ -54,7 +54,7 @@ namespace std __attribute__ ((__visibility__ ("default"))) { }; template inline typename _Niter_base<_Iterator>::iterator_type __niter_base(_Iterator __it) { } - template inline typename __gnu_cxx::__enable_if::__value, _OutputIterator>::__type __fill_n_a(_OutputIterator __first, _Size __n, const _Tp& __value) { + template inline typename __gnu_cxx::__enable_if::__value, _OutputIterator>::__type __fill_n_a(_OutputIterator __first, _Size __n, const _Tp& __value) { for (__decltype(__n + 0) __niter = __n; __niter > 0; --__niter, ++__first) *__first = __value; diff --git a/libstdc++-v3/include/bits/cpp_type_traits.h b/libstdc++-v3/include/bits/cpp_type_traits.h index 4312f32a4e0..8f966dfbc2a 100644 --- a/libstdc++-v3/include/bits/cpp_type_traits.h +++ b/libstdc++-v3/include/bits/cpp_type_traits.h @@ -387,9 +387,9 @@ __INT_N(__GLIBCXX_TYPE_INT_N_3) // // A scalar type is an arithmetic type or a pointer type - // + // template - struct __is_scalar + struct __is_arith_or_ptr : public __traitor<__is_arithmetic<_Tp>, __is_pointer<_Tp> > { }; diff --git a/libstdc++-v3/include/bits/stl_algobase.h b/libstdc++-v3/include/bits/stl_algobase.h index 4a6f8195d98..3922386f834 100644 --- a/libstdc++-v3/include/bits/stl_algobase.h +++ b/libstdc++-v3/include/bits/stl_algobase.h @@ -911,7 +911,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER template _GLIBCXX20_CONSTEXPR inline typename - __gnu_cxx::__enable_if::__value, void>::__type + __gnu_cxx::__enable_if::__value, void>::__type __fill_a1(_ForwardIterator __first, _ForwardIterator __last, const _Tp& __value) { @@ -922,7 +922,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER template _GLIBCXX20_CONSTEXPR inline typename - __gnu_cxx::__enable_if<__is_scalar<_Tp>::__value, void>::__type + __gnu_cxx::__enable_if<__is_arith_or_ptr<_Tp>::__value, void>::__type __fill_a1(_ForwardIterator __first, _ForwardIterator __last, const _Tp& __value) { @@ -1060,7 +1060,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER template _GLIBCXX20_CONSTEXPR inline typename - __gnu_cxx::__enable_if::__value, _OutputIterator>::__type + __gnu_cxx::__enable_if::__value, _OutputIterator>::__type __fill_n_a1(_OutputIterator __first, _Size __n, const _Tp& __value) { for (; __n > 0; --__n, (void) ++__first) @@ -1071,7 +1071,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER template _GLIBCXX20_CONSTEXPR inline typename - __gnu_cxx::__enable_if<__is_scalar<_Tp>::__value, _OutputIterator>::__type + __gnu_cxx::__enable_if<__is_arith_or_ptr<_Tp>::__value, _OutputIterator>::__type __fill_n_a1(_OutputIterator __first, _Size __n, const _Tp& __value) { const _Tp __tmp = __value; diff --git a/libstdc++-v3/include/bits/valarray_array.h b/libstdc++-v3/include/bits/valarray_array.h index 222fd5fd900..af259383648 100644 --- a/libstdc++-v3/include/bits/valarray_array.h +++ b/libstdc++-v3/include/bits/valarray_array.h @@ -90,7 +90,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION inline void __valarray_default_construct(_Tp* __b, _Tp* __e) { - _Array_default_ctor<_Tp, __is_scalar<_Tp>::__value>::_S_do_it(__b, __e); + _Array_default_ctor<_Tp, __is_arith_or_ptr<_Tp>::__value>::_S_do_it(__b, __e); } // Turn a raw-memory into an array of _Tp filled with __t diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 2bd607a8b8f..a25e65aaa5c 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -678,11 +678,18 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION struct is_member_pointer; /// is_scalar +#if __has_builtin(__is_scalar) + template + struct is_scalar + : public __bool_constant<__is_scalar(_Tp)> + { }; +#else template struct is_scalar : public __or_, is_enum<_Tp>, is_pointer<_Tp>, is_member_pointer<_Tp>, is_null_pointer<_Tp>>::type { }; +#endif /// is_compound template -- 2.39.2