From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Meissner <meissner@linux.ibm.com>,
gcc-patches@gcc.gnu.org, "Kewen.Lin" <linkw@linux.ibm.com>,
David Edelsohn <dje.gcc@gmail.com>,
Peter Bergner <bergner@linux.ibm.com>,
Will Schmidt <will_schmidt@vnet.ibm.com>
Subject: Re: [PATCH V4] Rework 128-bit complex multiply and divide.
Date: Fri, 17 Mar 2023 14:35:16 -0500 [thread overview]
Message-ID: <20230317193516.GF25951@gate.crashing.org> (raw)
In-Reply-To: <ZAqKlNLJl4jMFGVa@toto.the-meissners.org>
Hi!
On Thu, Mar 09, 2023 at 08:40:36PM -0500, Michael Meissner wrote:
> PR target/109067
> * config/rs6000/rs6000.cc (create_complex_muldiv): Delete.
> (init_float128_ieee): Delete code to switch complex multiply and divide
> for long double.
> (complex_multiply_builtin_code): New helper function.
> (complex_divide_builtin_code): Likewise.
> (rs6000_mangle_decl_assembler_name): Add support for mangling the name
> of complex 128-bit multiply and divide built-in functions.
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/powerpc/divic3-1.c
> +/* { dg-final { scan-assembler "__divtc3" } } */
/* { dg-final { scan-assembler {\m__divtc3\M} } } */
It might well be that we can use a sloppier regexp here, but why would
we do that? It is a good thing to use the \m and \M constraint escapes
pretty much always.
Similar for the other three testcases of course.
This patch is okay for trunk, if you have tested it on all
configurations (powerpc-linux, powerpc64-linux, powerpc64le-linux with
and without default IEEE128 long double at least). Thank you!
Does this need backports?
Segher
next prev parent reply other threads:[~2023-03-17 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 1:40 Michael Meissner
2023-03-17 19:35 ` Segher Boessenkool [this message]
2023-03-20 17:43 ` Michael Meissner
2023-03-20 20:25 ` Michael Meissner
2023-03-20 23:00 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230317193516.GF25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=meissner@linux.ibm.com \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).