From: Jonathan Wakely <jwakely@redhat.com>
To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: [committed] libstdc++: Add const to hash<coroutine_handle<P>>::operator() [PR109165]
Date: Fri, 17 Mar 2023 20:36:01 +0000 [thread overview]
Message-ID: <20230317203601.55027-1-jwakely@redhat.com> (raw)
Tested x86_64-linux. Pushed to trunk. gcc-12 backport needed too.
-- >8 --
libstdc++-v3/ChangeLog:
PR libstdc++/109165
* include/std/coroutine (hash<>::operator()): Add const.
* testsuite/18_support/coroutines/hash.cc: New test.
---
libstdc++-v3/include/std/coroutine | 2 +-
.../testsuite/18_support/coroutines/hash.cc | 22 +++++++++++++++++++
2 files changed, 23 insertions(+), 1 deletion(-)
create mode 100644 libstdc++-v3/testsuite/18_support/coroutines/hash.cc
diff --git a/libstdc++-v3/include/std/coroutine b/libstdc++-v3/include/std/coroutine
index f6e65566f10..b0ca18949db 100644
--- a/libstdc++-v3/include/std/coroutine
+++ b/libstdc++-v3/include/std/coroutine
@@ -345,7 +345,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
struct hash<coroutine_handle<_Promise>>
{
size_t
- operator()(const coroutine_handle<_Promise>& __h) noexcept
+ operator()(const coroutine_handle<_Promise>& __h) const noexcept
{
return reinterpret_cast<size_t>(__h.address());
}
diff --git a/libstdc++-v3/testsuite/18_support/coroutines/hash.cc b/libstdc++-v3/testsuite/18_support/coroutines/hash.cc
new file mode 100644
index 00000000000..68e5e640477
--- /dev/null
+++ b/libstdc++-v3/testsuite/18_support/coroutines/hash.cc
@@ -0,0 +1,22 @@
+// { dg-options "-std=gnu++2a" }
+// { dg-do run { target c++2a } }
+
+#include <coroutine>
+#include <testsuite_hooks.h>
+
+void
+test01()
+{
+ std::hash<std::noop_coroutine_handle> h;
+ std::size_t v = h(std::noop_coroutine());
+
+ const auto& ch = h;
+ std::size_t v2 = h(std::noop_coroutine()); // PR libstdc++/109165
+
+ VERIFY( v2 == v );
+}
+
+int main()
+{
+ test01();
+}
--
2.39.2
next reply other threads:[~2023-03-17 20:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 20:36 Jonathan Wakely [this message]
2023-03-18 0:49 ` Nathaniel Shead
2023-03-18 9:55 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230317203601.55027-1-jwakely@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).