From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 0B1473858C50 for ; Sat, 18 Mar 2023 08:04:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0B1473858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x333.google.com with SMTP id bg16-20020a05600c3c9000b003eb34e21bdfso6327553wmb.0 for ; Sat, 18 Mar 2023 01:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679126662; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mqj3eoizRLYpARgkZdhtFQjWuK9djeyoVu1xTCjA+0Q=; b=AWN0WDu8+PSd7em2ca5Qht6XPiP//s/112YbDDFs2DaEZhJcwRTi+XpK4h42C3+3Nh lw50z+J5BT2+6hB7tuL3o/FDXkVor9Ne8i/WWEs1+eRaj5j6jyOXk1TLamZuwIhUcue+ 2JXhvUbMXRiHWArKOKYRAx5n00BXwV3pzs7/4hhIkuwPDtoxMu5MLJruuYOHCNvySDxh X+i0bt++pNkAesoVBN+Ujqw67MBand4vmCdRulfXKNdLKX0moOEnYUEKHBXtjIlz6U1q eKHOMkgWOfl+SQ/LBVmTqUR6azl0bU+FCCjFVkSJb4/a3lbI+khFJql834X4z9w5GLgg H2QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679126662; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mqj3eoizRLYpARgkZdhtFQjWuK9djeyoVu1xTCjA+0Q=; b=Pj+DWX3054aUsVi1pYA83VDUvcWtLgNBBc9GAaTgvaujMBZdDtN0tcty7Wb211liaE Zvmc0HdfILoJ50J9EG/5d2HizhoBW07wUOH3K9slQ9sRdobReU+nkRB14mQw8rwyY+om 4FnR90zO5Vw7uBDGsPhNYiWE2lqzwd/4KD2rB5lJkT4AJMTtNHYPl5qBlcj5cpydL36B T2MSKzUA2JrFNzGCYXNwRotMXnvO7uAVvPC3d3UB3zc4CPqNxn3bYykDGr54Qe+aw8aN LMlrQdg5ncbL6poLbtrWhs0w+Ssmafm0G2/kD9bBkq5bS/HcTHOTRr8kO4Ebpo+B4dfy eoQQ== X-Gm-Message-State: AO0yUKWsyGyEoqErB4LH8TtE5UaS3hhr+ZrN9tvg857eQLDPFV/ykcph mvxXHrXyK8K2fMXfoWUlowOWvXtFECk= X-Google-Smtp-Source: AK7set8YW4tU8t2e+XOTRC1iwl/J5fJFYIR8eprKgckpvgMuFdnTFNep7LN1uOq3fz5ft8lQhiAQLw== X-Received: by 2002:a05:600c:4452:b0:3e1:374:8b66 with SMTP id v18-20020a05600c445200b003e103748b66mr26263510wmn.40.1679126662338; Sat, 18 Mar 2023 01:04:22 -0700 (PDT) Received: from localhost (cpc1-brnt4-2-0-cust862.4-2.cable.virginm.net. [86.9.131.95]) by smtp.gmail.com with ESMTPSA id az40-20020a05600c602800b003e2096da239sm10245677wmb.7.2023.03.18.01.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 01:04:21 -0700 (PDT) From: Stafford Horne To: GCC patches Cc: Linux OpenRISC , Stafford Horne Subject: [PATCH] or1k: Do not clear existing FPU exceptions before updating Date: Sat, 18 Mar 2023 17:04:05 +0900 Message-Id: <20230318080405.2799610-1-shorne@gmail.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: We should always carry the exceptions forward. This bug was found when working on testing glibc math tests, many tests were failing with Overflow and Underflow flags not set. This was traced to here. libgcc/ChangeLog: * config/or1k/sfp-machine.h (FP_HANDLE_EXCEPTIONS): Remove statement clearing existing exceptions. --- libgcc/config/or1k/sfp-machine.h | 1 - 1 file changed, 1 deletion(-) diff --git a/libgcc/config/or1k/sfp-machine.h b/libgcc/config/or1k/sfp-machine.h index 162c6bc5326..c804270fb3c 100644 --- a/libgcc/config/or1k/sfp-machine.h +++ b/libgcc/config/or1k/sfp-machine.h @@ -73,7 +73,6 @@ do { \ do { \ if (__builtin_expect (_fex, 0)) \ { \ - _fpcsr &= ~FP_EX_ALL; \ _fpcsr |= _fex; \ __asm__ volatile ("l.mtspr r0,%0,20" : : "r" (_fpcsr)); \ } \ -- 2.39.1