From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3A6053858C50 for ; Thu, 23 Mar 2023 20:35:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A6053858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679603741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iRG0GFW4ve530Oyd0ikM8rVAdLjjdcAe+FjXU4WL87c=; b=JlAJe271xUwr478uAY5cNiITA5bLQknGJrKH9xf0o4TGDHg9ofA6SMI19nMmLBETd98FNU zMJ4W9jBjeH482MFS5nH2zCRE6iK42WuLtNxRHDctZE4Vxq11SGMS78bWA8mtxkcI5z5S0 GKKKfnnVS1gyDWq5B4OoWRgeHjhhnUM= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-VH9N7dw9MAeT6Jck7O7EkA-1; Thu, 23 Mar 2023 16:35:18 -0400 X-MC-Unique: VH9N7dw9MAeT6Jck7O7EkA-1 Received: by mail-qv1-f69.google.com with SMTP id a10-20020a0ccdca000000b005d70160fbb0so3275010qvn.21 for ; Thu, 23 Mar 2023 13:35:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679603711; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iRG0GFW4ve530Oyd0ikM8rVAdLjjdcAe+FjXU4WL87c=; b=0xbi9PW/np1L3B0hv2hRBiq0b3j8kK99CJL1ikPucrlYj4oI7EIq1tyGMQ6KHbDaSA EcJrcJfoIN5T18cECAJ9B/A+mC7KwTAez24wHXizihUuyTjaJkfQ7uNq0cAxBvL39ovZ XMCrnQAFRs2pFvHu1+266q1ZrqbZk8vI0w/6Gj14+s35eysPChSbwk91Zw3/50QM3RlR MQI/qolNM4X0/oaFGkWnbC4b1bJ9qMO7JFXTGZ78W0jbSbBVyCyjDejUsfGiz/R0hK1Z pnaD6355x79xzc4z7ale0vN958OfsFcXdp+VzgcoVXGbCoKbGLUeHsCM4JSSmx/nQfKr RQ/A== X-Gm-Message-State: AAQBX9cyJCtvuw7FrgrgpS58bgiSluUx99poAyJ6BBRnUUFEHlbIPAAp WTeqNHCnmR48eDNOVS/2kxPLhWbTlMxIGVSy6OcfE6UO9KwBSNkw2ZWSqTa0jmArF8ypRs/TIvo FUV6KyvV+SA7b3ev9RAt47oERdv2xfIdNF/K4LboM29cQuFjHnEbdxLgab9iiOl5NbFs5dn2CjQ == X-Received: by 2002:a05:6214:27c6:b0:5cd:f9fd:f66a with SMTP id ge6-20020a05621427c600b005cdf9fdf66amr530974qvb.0.1679603710872; Thu, 23 Mar 2023 13:35:10 -0700 (PDT) X-Google-Smtp-Source: AKy350ZrX+75VQVtMHzCzn/OpIZDD/tbHfeNzw5ijJMoD9eDvyssvUIjTYJzC+BimbE+X5xiTnxOBg== X-Received: by 2002:a05:6214:27c6:b0:5cd:f9fd:f66a with SMTP id ge6-20020a05621427c600b005cdf9fdf66amr530927qvb.0.1679603710451; Thu, 23 Mar 2023 13:35:10 -0700 (PDT) Received: from jason.cygnus.com (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id h26-20020ac846da000000b003bfb5fd72a7sm12188273qto.86.2023.03.23.13.35.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 13:35:10 -0700 (PDT) From: Jason Merrill To: gcc-patches@gcc.gnu.org, Jakub Jelinek Subject: [PATCH RFC] c-family: -Wsequence-point and COMPONENT_REF [PR107163] Date: Thu, 23 Mar 2023 16:35:07 -0400 Message-Id: <20230323203507.2960052-1-jason@redhat.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tested x86_64-pc-linux-gnu. Jakub, does this make sense to you? Do we have a way of testing for compile-hog regressions? -- 8< -- The patch for PR91415 fixed -Wsequence-point to treat shifts and ARRAY_REF as sequenced in C++17, and COMPONENT_REF as well. But this is unnecessary for COMPONENT_REF, since the RHS is just a FIELD_DECL with no actual evaluation, and in this testcase handling COMPONENT_REF as sequenced blows up fast in a deep inheritance tree. PR c++/107163 gcc/c-family/ChangeLog: * c-common.cc (verify_tree): Don't use sequenced handling for COMPONENT_REF. --- gcc/c-family/c-common.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/gcc/c-family/c-common.cc b/gcc/c-family/c-common.cc index bfb950e56db..a803cf94c68 100644 --- a/gcc/c-family/c-common.cc +++ b/gcc/c-family/c-common.cc @@ -2154,7 +2154,6 @@ verify_tree (tree x, struct tlist **pbefore_sp, struct tlist **pno_sp, case LSHIFT_EXPR: case RSHIFT_EXPR: - case COMPONENT_REF: case ARRAY_REF: if (cxx_dialect >= cxx17) goto sequenced_binary; base-commit: 4872e46e080c6695dfe1f9dc9db26b4703bc348c -- 2.31.1