From: Ken Matsui <kmatsui@cs.washington.edu>
To: gcc-patches@gcc.gnu.org
Cc: libstdc++@gcc.gnu.org, Ken Matsui <kmatsui@cs.washington.edu>
Subject: [PATCH 03/10] c++: implement __is_function built-in trait
Date: Sat, 25 Mar 2023 21:30:25 -0700 [thread overview]
Message-ID: <20230326043032.11096-4-kmatsui@cs.washington.edu> (raw)
In-Reply-To: <20230326043032.11096-1-kmatsui@cs.washington.edu>
This patch implements built-in trait for std::is_function.
gcc/cp/ChangeLog:
* cp-trait.def: Define __is_function.
* constraint.cc (diagnose_trait_expr): Handle CPTK_IS_FUNCTION.
* semantics.cc (trait_expr_value): Likewise.
(finish_trait_expr): Likewise.
gcc/testsuite/ChangeLog:
* g++.dg/ext/has-builtin-1.C: Test existence of __is_function.
* g++.dg/ext/is_function.C: New test.
Signed-off-by: Ken Matsui <kmatsui@cs.washington.edu>
---
gcc/cp/constraint.cc | 3 ++
gcc/cp/cp-trait.def | 1 +
gcc/cp/semantics.cc | 4 ++
gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 ++
gcc/testsuite/g++.dg/ext/is_function.C | 58 ++++++++++++++++++++++++
5 files changed, 69 insertions(+)
create mode 100644 gcc/testsuite/g++.dg/ext/is_function.C
diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc
index 23e5bc24dbb..500ac9177c7 100644
--- a/gcc/cp/constraint.cc
+++ b/gcc/cp/constraint.cc
@@ -3750,6 +3750,9 @@ diagnose_trait_expr (tree expr, tree args)
case CPTK_IS_UNION:
inform (loc, " %qT is not a union", t1);
break;
+ case CPTK_IS_FUNCTION:
+ inform (loc, " %qT is not a function", t1);
+ break;
case CPTK_IS_AGGREGATE:
inform (loc, " %qT is not an aggregate", t1);
break;
diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def
index 63a64152ce6..99195201676 100644
--- a/gcc/cp/cp-trait.def
+++ b/gcc/cp/cp-trait.def
@@ -83,6 +83,7 @@ DEFTRAIT_EXPR (IS_TRIVIALLY_ASSIGNABLE, "__is_trivially_assignable", 2)
DEFTRAIT_EXPR (IS_TRIVIALLY_CONSTRUCTIBLE, "__is_trivially_constructible", -1)
DEFTRAIT_EXPR (IS_TRIVIALLY_COPYABLE, "__is_trivially_copyable", 1)
DEFTRAIT_EXPR (IS_UNION, "__is_union", 1)
+DEFTRAIT_EXPR (IS_FUNCTION, "__is_function", 1)
DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, "__reference_constructs_from_temporary", 2)
DEFTRAIT_EXPR (REF_CONVERTS_FROM_TEMPORARY, "__reference_converts_from_temporary", 2)
/* FIXME Added space to avoid direct usage in GCC 13. */
diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc
index b17fbf8005d..36fe370da2d 100644
--- a/gcc/cp/semantics.cc
+++ b/gcc/cp/semantics.cc
@@ -11993,6 +11993,9 @@ trait_expr_value (cp_trait_kind kind, tree type1, tree type2)
case CPTK_IS_ENUM:
return type_code1 == ENUMERAL_TYPE;
+ case CPTK_IS_FUNCTION:
+ return type_code1 == FUNCTION_TYPE;
+
case CPTK_IS_FINAL:
return CLASS_TYPE_P (type1) && CLASSTYPE_FINAL (type1);
@@ -12205,6 +12208,7 @@ finish_trait_expr (location_t loc, cp_trait_kind kind, tree type1, tree type2)
case CPTK_IS_UNION:
case CPTK_IS_SAME:
case CPTK_IS_REFERENCE:
+ case CPTK_IS_FUNCTION:
break;
case CPTK_IS_LAYOUT_COMPATIBLE:
diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C
index b697673790c..90eb00ebf2d 100644
--- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C
+++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C
@@ -149,3 +149,6 @@
#if !__has_builtin (__is_reference)
# error "__has_builtin (__is_reference) failed"
#endif
+#if !__has_builtin (__is_function)
+# error "__has_builtin (__is_function) failed"
+#endif
diff --git a/gcc/testsuite/g++.dg/ext/is_function.C b/gcc/testsuite/g++.dg/ext/is_function.C
new file mode 100644
index 00000000000..2e1594b12ad
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ext/is_function.C
@@ -0,0 +1,58 @@
+// { dg-do compile { target c++11 } }
+
+#include <testsuite_tr1.h>
+
+using namespace __gnu_test;
+
+#define SA(X) static_assert((X),#X)
+#define SA_TEST_CATEGORY(TRAIT, TYPE, EXPECT) \
+ SA(TRAIT(TYPE) == EXPECT); \
+ SA(TRAIT(const TYPE) == EXPECT); \
+ SA(TRAIT(volatile TYPE) == EXPECT); \
+ SA(TRAIT(const volatile TYPE) == EXPECT)
+
+struct A
+{ void fn(); };
+
+template<typename>
+struct AHolder { };
+
+template<class T, class U>
+struct AHolder<U T::*>
+{ using type = U; };
+
+// Positive tests.
+SA(__is_function(int (int)));
+SA(__is_function(ClassType (ClassType)));
+SA(__is_function(float (int, float, int[], int&)));
+SA(__is_function(int (int, ...)));
+SA(__is_function(bool (ClassType) const));
+SA(__is_function(AHolder<decltype(&A::fn)>::type));
+
+void fn();
+SA(__is_function(decltype(fn)));
+
+// Negative tests.
+SA_TEST_CATEGORY(__is_function, int, false);
+SA_TEST_CATEGORY(__is_function, int*, false);
+SA_TEST_CATEGORY(__is_function, int&, false);
+SA_TEST_CATEGORY(__is_function, void, false);
+SA_TEST_CATEGORY(__is_function, void*, false);
+SA_TEST_CATEGORY(__is_function, void**, false);
+SA_TEST_CATEGORY(__is_function, std::nullptr_t, false);
+
+SA_TEST_CATEGORY(__is_function, AbstractClass, false);
+SA(!__is_function(int(&)(int)));
+SA(!__is_function(int(*)(int)));
+
+SA_TEST_CATEGORY(__is_function, A, false);
+SA_TEST_CATEGORY(__is_function, decltype(&A::fn), false);
+
+struct FnCallOverload
+{ void operator()(); };
+SA_TEST_CATEGORY(__is_function, FnCallOverload, false);
+
+// Sanity check.
+SA_TEST_CATEGORY(__is_function, ClassType, false);
+SA_TEST_CATEGORY(__is_function, IncompleteClass, false);
+SA_TEST_CATEGORY(__is_function, IncompleteUnion, false);
--
2.40.0
next prev parent reply other threads:[~2023-03-26 4:31 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 4:30 [PATCH 00/10] c++, libstdc++: get std::is_object to dispatch to new built-in traits Ken Matsui
2023-03-26 4:30 ` [PATCH 01/10] c++: implement __is_reference built-in trait Ken Matsui
2023-03-26 4:30 ` [PATCH 02/10] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-03-26 4:30 ` Ken Matsui [this message]
2023-03-26 4:30 ` [PATCH 04/10] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-03-26 4:30 ` [PATCH 05/10] libstdc++: use std::is_void instead of __is_void in helper_functions.h Ken Matsui
2023-03-26 4:30 ` [PATCH 06/10] libstdc++: remove unused __is_void in cpp_type_traits.h Ken Matsui
2023-03-26 4:30 ` [PATCH 07/10] c++: rename __is_void defined in pr46567.C to ____is_void Ken Matsui
2023-03-26 4:30 ` [PATCH 08/10] c++: implement __is_void built-in trait Ken Matsui
2023-03-26 4:30 ` [PATCH 09/10] libstdc++: use new built-in trait __is_void for std::is_void Ken Matsui
2023-03-26 4:30 ` [PATCH 10/10] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-03-30 18:32 ` [PATCH 0/7] c++, libstdc++: get std::is_object to " Ken Matsui
2023-03-30 18:39 ` [PATCH v2 " Ken Matsui
2023-03-30 18:39 ` [PATCH v2 1/7] c++: implement __is_reference built-in trait Ken Matsui
2023-03-30 18:39 ` [PATCH v2 2/7] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-03-30 18:39 ` [PATCH v2 3/7] c++: implement __is_function built-in trait Ken Matsui
2023-03-30 18:39 ` [PATCH v2 4/7] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-03-30 18:39 ` [PATCH v2 5/7] c++, libstdc++: implement __is_void built-in trait Ken Matsui
2023-03-30 18:39 ` [PATCH v2 6/7] libstdc++: use new built-in trait __is_void for std::is_void Ken Matsui
2023-03-30 18:39 ` [PATCH v2 7/7] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-04-02 7:53 ` [PATCH v3 0/6] c++, libstdc++: get std::is_object to " Ken Matsui
2023-04-02 7:53 ` [PATCH v3 1/6] c++: implement __is_reference built-in trait Ken Matsui
2023-04-02 7:53 ` [PATCH v3 2/6] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-04-02 7:53 ` [PATCH v3 3/6] c++: implement __is_function built-in trait Ken Matsui
2023-04-02 7:53 ` [PATCH v3 4/6] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-06-09 17:54 ` Patrick Palka
2023-06-09 23:53 ` Ken Matsui
2023-04-02 7:53 ` [PATCH v3 5/6] c++, libstdc++: implement __is_void built-in trait Ken Matsui
2023-04-02 7:53 ` [PATCH v3 6/6] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-06-11 2:43 ` [PATCH v4 0/6] c++, libstdc++: get std::is_object to " Ken Matsui
2023-06-11 2:43 ` [PATCH v4 1/6] c++: implement __is_reference built-in trait Ken Matsui
2023-06-11 2:43 ` [PATCH v4 2/6] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-06-12 18:09 ` François Dumont
2023-06-12 18:13 ` Ken Matsui
2023-06-11 2:43 ` [PATCH v4 3/6] c++: implement __is_function built-in trait Ken Matsui
2023-06-11 2:43 ` [PATCH v4 4/6] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-06-11 2:43 ` [PATCH v4 5/6] c++, libstdc++: implement __is_void built-in trait Ken Matsui
2023-06-11 2:43 ` [PATCH v4 6/6] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-06-12 22:22 ` [PATCH v5 0/6] c++, libstdc++: get std::is_object to " Ken Matsui
2023-06-12 22:22 ` [PATCH v5 1/6] c++: implement __is_reference built-in trait Ken Matsui
2023-06-12 22:22 ` [PATCH v5 2/6] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-06-12 22:22 ` [PATCH v5 3/6] c++: implement __is_function built-in trait Ken Matsui
2023-06-12 22:22 ` [PATCH v5 4/6] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-06-12 22:22 ` [PATCH v5 5/6] c++, libstdc++: implement __is_void built-in trait Ken Matsui
2023-06-12 22:22 ` [PATCH v5 6/6] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-06-14 5:10 ` François Dumont
2023-06-14 5:25 ` Ken Matsui
2023-06-12 22:39 ` [PATCH v6 0/6] c++, libstdc++: get std::is_object to " Ken Matsui
2023-06-12 22:39 ` [PATCH v6 1/6] c++: implement __is_reference built-in trait Ken Matsui
2023-06-12 22:39 ` [PATCH v6 2/6] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-06-12 22:39 ` [PATCH v6 3/6] c++: implement __is_function built-in trait Ken Matsui
2023-06-12 22:39 ` [PATCH v6 4/6] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-06-12 22:39 ` [PATCH v6 5/6] c++, libstdc++: implement __is_void built-in trait Ken Matsui
2023-06-12 22:39 ` [PATCH v6 6/6] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-06-12 22:47 ` [PATCH v7 0/6] c++, libstdc++: get std::is_object to " Ken Matsui
2023-06-12 22:47 ` [PATCH v7 1/6] c++: implement __is_reference built-in trait Ken Matsui
2023-06-20 16:06 ` Patrick Palka
2023-06-12 22:47 ` [PATCH v7 2/6] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-06-20 16:07 ` Patrick Palka
2023-06-12 22:47 ` [PATCH v7 3/6] c++: implement __is_function built-in trait Ken Matsui
2023-06-20 16:05 ` Patrick Palka
2023-06-12 22:47 ` [PATCH v7 4/6] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-06-20 16:05 ` Patrick Palka
2023-06-12 22:47 ` [PATCH v7 5/6] c++, libstdc++: implement __is_void built-in trait Ken Matsui
2023-06-20 16:00 ` Patrick Palka
2023-06-12 22:47 ` [PATCH v7 6/6] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-06-15 10:49 ` [PATCH v7 0/6] c++, libstdc++: get std::is_object to " Ken Matsui
2023-06-20 13:19 ` Ken Matsui
2023-06-20 15:32 ` Patrick Palka
2023-06-24 15:12 ` Ken Matsui
2023-07-08 5:08 ` [PATCH v8 " Ken Matsui
2023-07-08 5:08 ` [PATCH v8 1/6] c++: implement __is_reference built-in trait Ken Matsui
2023-07-08 5:08 ` [PATCH v8 2/6] libstdc++: use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-07-12 10:08 ` Jonathan Wakely
2023-07-08 5:08 ` [PATCH v8 3/6] c++: implement __is_function built-in trait Ken Matsui
2023-07-08 5:08 ` [PATCH v8 4/6] libstdc++: use new built-in trait __is_function for std::is_function Ken Matsui
2023-07-12 10:10 ` Jonathan Wakely
2023-07-08 5:08 ` [PATCH v8 5/6] c++, libstdc++: implement __is_void built-in trait Ken Matsui
2023-07-08 5:08 ` [PATCH v8 6/6] libstdc++: make std::is_object dispatch to new built-in traits Ken Matsui
2023-07-13 2:33 ` [PATCH v10 0/5] c++, libstdc++: Make " Ken Matsui
2023-07-13 2:33 ` [PATCH v10 1/5] c++: Implement __is_reference built-in trait Ken Matsui
2023-07-13 2:33 ` [PATCH v10 2/5] libstdc++: Use new built-in trait __is_reference for std::is_reference Ken Matsui
2023-07-13 2:56 ` Ken Matsui
2023-09-04 15:00 ` [PING][PATCH " Ken Matsui
2023-07-13 2:33 ` [PATCH v10 3/5] c++: Implement __is_function built-in trait Ken Matsui
2023-07-13 2:41 ` Ken Matsui
2023-08-22 19:52 ` Patrick Palka
2023-09-04 15:00 ` [PING][PATCH " Ken Matsui
2023-07-13 2:33 ` [PATCH v10 4/5] libstdc++: Use new built-in trait __is_function for std::is_function Ken Matsui
2023-08-08 20:35 ` Jonathan Wakely
2023-07-13 2:33 ` [PATCH v10 5/5] libstdc++: Make std::is_object dispatch to new built-in traits Ken Matsui
2023-09-01 13:00 ` [PING][PATCH " Ken Matsui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230326043032.11096-4-kmatsui@cs.washington.edu \
--to=kmatsui@cs.washington.edu \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).