From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id BF17C3858CDA for ; Thu, 30 Mar 2023 15:29:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF17C3858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 32UFSkv4014905; Thu, 30 Mar 2023 10:28:46 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 32UFSjsZ014904; Thu, 30 Mar 2023 10:28:45 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 30 Mar 2023 10:28:45 -0500 From: Segher Boessenkool To: Bernhard Reutner-Fischer Cc: Ajit Agarwal via Gcc-patches , Ajit Agarwal , Peter Bergner , Richard Biener , Jeff Law Subject: Re: [PATCH v2] rtl-optimization: ppc backend generates unnecessary extension. Message-ID: <20230330152845.GP25951@gate.crashing.org> References: <05b5dcba-9343-0b6c-44a7-d4a6d128e7aa@linux.ibm.com> <20230330162851.6ac61e1f@nbbrfq> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230330162851.6ac61e1f@nbbrfq> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On Thu, Mar 30, 2023 at 04:28:51PM +0200, Bernhard Reutner-Fischer wrote: > On Thu, 30 Mar 2023 17:30:43 +0530 > Ajit Agarwal via Gcc-patches wrote: > > * ree.cc(is_feasible_elim_across_basic_blocks): > > We often use the lispy _p suffix for predicates. > Maybe eliminate_across_bbs_p would be shorter. A bit shorter, but much less clear, and that is the actual reason to keep names short -- so this misses the goal. Also, many things currently called _p are not predicates (and/or in some cases are not even functions!) > > + if (use == NULL) return NULL; > > Missing newline before return. And better style is if (!use) > > +#if 0 > > /* Get all the reaching definitions of an instruction. The definitions are > > desired for REG used in INSN. Return the definition list or NULL if a > > definition is missing. If DEST is non-NULL, additionally push the INSN > > @@ -593,7 +646,7 @@ get_defs (rtx_insn *insn, rtx reg, vec *dest) > > > > return ref_chain; > > } > > - > > +#endif > > Why did you move get_defs? And we should not normally have #if 0, too. Segher