From: Segher Boessenkool <segher@kernel.crashing.org>
To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com
Subject: Re: [PATCH v2 1/2] combine: Split code out of make_compound_operation_int
Date: Fri, 31 Mar 2023 06:06:45 -0500 [thread overview]
Message-ID: <20230331110645.GU25951@gate.crashing.org> (raw)
In-Reply-To: <mptfsae15yg.fsf@arm.com>
Hi!
On Thu, Mar 09, 2023 at 12:09:59PM +0000, Richard Sandiford wrote:
> This patch just splits some code out of make_compound_operation_int
> into a new function called make_compound_operation_and. It is a
> prerequisite for the fix for PR106594.
>
> It might (or might not) make sense to put more of the existing
> "and" handling into the new function, so that the subreg+lshiftrt
> case can be handled through recursion rather than duplication.
> But that's certainly not necessary to fix the bug, so is at
> best stage 1 material.
>
> No behavioural change intended.
That doesn't sound as if you are very sure about things. I'll just
pretend it says "no functional changes" :-)
(*Is* this a pure refactoring?)
Segher
next prev parent reply other threads:[~2023-03-31 11:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 12:08 [PATCH v2 0/2] Series of patch to fix PR106594 Richard Sandiford
2023-03-09 12:09 ` [PATCH v2 1/2] combine: Split code out of make_compound_operation_int Richard Sandiford
2023-03-31 11:06 ` Segher Boessenkool [this message]
2023-03-31 12:13 ` Richard Sandiford
2023-03-09 12:10 ` [PATCH v2 2/2] combine: Try harder to form zero_extends [PR106594] Richard Sandiford
2023-03-31 12:16 ` Segher Boessenkool
2023-03-31 14:06 ` Richard Sandiford
2023-03-31 14:35 ` Segher Boessenkool
2023-03-31 14:55 ` Richard Sandiford
2023-03-27 12:14 ` [PATCH v2 0/2] Series of patch to fix PR106594 Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331110645.GU25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).