From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id F04013858C52; Sun, 2 Apr 2023 15:05:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F04013858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x533.google.com with SMTP id y4so107931051edo.2; Sun, 02 Apr 2023 08:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680447940; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S5Td04uYYTvHptqbR1rRss3IeqGirYjgywGM8cdKzNk=; b=iCeATkZG9RbYGM2xYp3Ra2ME5x2/SoknszRsXLj7cWo9HWmvBQN+1K4lnPC4f2VYAM i61PouJ5nbEFnegDvAQg0a8k5/BW9RQXdumzD/6JwIwYlARZIdmrxMoO22usoiyRy3Y8 1pzMigy3XSkY5M81JNARQD9edczV5vMY6RaWY2uIUi38UqaDdKOQ5gQfXF3EVLlzRoW3 7V02JXgfsce8Bz1q7MqLP5qrNZNFqORpIJhuhGkYDd/F/5pr8OvS5ocfSgEdbThD/8UX 9KasCCz0eHnWlwMZV1hWJCvTqke/gTmiU7d/2VoOAHgDCqPkuOrvunbrCgBCEk94DgTk atGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680447940; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S5Td04uYYTvHptqbR1rRss3IeqGirYjgywGM8cdKzNk=; b=sd5LBQiSaa3P+XrFObrduyVHe7kxirezNtaXrFS3xY7wEtCoouVkYHu5OsLE2eWOAX NQ9ImYJLsvQ/LwAGMk5iyZRxy15WJzsX6OO5QG1uvc2foW0OtVLaIPIOR6QhyZw4WcRc W4F6Ei/f4jkAaQwx1hlDKXcVJCRJjA19CgLmC+M2QSDH879UaBpBnnONL4eZd/gtgTu/ DScc7uBDZGVI8CwJACc+Jdb5gceNokER9qYlEzyYUbBG8TXslNcknuuOqyB2v4TWeC57 Bb+p0tI9zB9LYw9HPSMDS7UC4cZV6IG7dmGQ7H0luAnFQ8vq5XSOkicZ8mLs0ogxOWKm nkDA== X-Gm-Message-State: AAQBX9fnRPtkCeu+wIUn2N2EGOCnOomiqgYEnxRIvxaGcDQjeWsfZ7ol UbSRMWEUNmppiI0wgKsUbmZ+KWqe9v8= X-Google-Smtp-Source: AKy350YsiSUf59DnL0+XD3XpKM3OOovvYbT4w39ByUf8bd8IC8fVKL05kQWlrFyD8oJvlIf+nkYBWw== X-Received: by 2002:a17:906:1e08:b0:93b:d1ee:5f41 with SMTP id g8-20020a1709061e0800b0093bd1ee5f41mr33805693ejj.31.1680447940308; Sun, 02 Apr 2023 08:05:40 -0700 (PDT) Received: from nbbrfq ([2001:871:227:1e16:8ec:e883:b72a:18fd]) by smtp.gmail.com with ESMTPSA id t28-20020a50ab5c000000b005024faae65esm3366788edc.10.2023.04.02.08.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 08:05:38 -0700 (PDT) Received: from b by nbbrfq with local (Exim 4.96) (envelope-from ) id 1pizGz-000Ad3-1a; Sun, 02 Apr 2023 17:05:37 +0200 From: Bernhard Reutner-Fischer To: gcc-patches@gcc.gnu.org Cc: Bernhard Reutner-Fischer , Arthur Cohen , Philip Herron Subject: [PATCH 2/3] rust: Fix memory leak in compile_{integer,float}_literal Date: Sun, 2 Apr 2023 17:05:14 +0200 Message-Id: <20230402150515.40826-3-rep.dot.nop@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Bernhard Reutner-Fischer Cc: Arthur Cohen Cc: Philip Herron gcc/rust/ChangeLog: * backend/rust-compile-expr.cc (CompileExpr::compile_integer_literal): (CompileExpr::compile_float_literal): Fix memory leak. --- gcc/rust/backend/rust-compile-expr.cc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gcc/rust/backend/rust-compile-expr.cc b/gcc/rust/backend/rust-compile-expr.cc index 436fc924a13..82078b81953 100644 --- a/gcc/rust/backend/rust-compile-expr.cc +++ b/gcc/rust/backend/rust-compile-expr.cc @@ -2119,6 +2119,7 @@ CompileExpr::compile_integer_literal (const HIR::LiteralExpr &expr, if (mpz_init_set_str (ival, literal_value.as_string ().c_str (), 10) != 0) { rust_error_at (expr.get_locus (), "bad number in literal"); + mpz_clear (ival); return error_mark_node; } @@ -2133,6 +2134,9 @@ CompileExpr::compile_integer_literal (const HIR::LiteralExpr &expr, rust_error_at (expr.get_locus (), "integer overflows the respective type %<%s%>", tyty->get_name ().c_str ()); + mpz_clear (type_min); + mpz_clear (type_max); + mpz_clear (ival); return error_mark_node; } @@ -2158,6 +2162,7 @@ CompileExpr::compile_float_literal (const HIR::LiteralExpr &expr, != 0) { rust_error_at (expr.get_locus (), "bad number in literal"); + mpfr_clear (fval); return error_mark_node; } @@ -2179,9 +2184,11 @@ CompileExpr::compile_float_literal (const HIR::LiteralExpr &expr, rust_error_at (expr.get_locus (), "decimal overflows the respective type %<%s%>", tyty->get_name ().c_str ()); + mpfr_clear (fval); return error_mark_node; } + mpfr_clear (fval); return real_value; } -- 2.30.2