From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by sourceware.org (Postfix) with ESMTPS id 856183858D1E for ; Tue, 4 Apr 2023 05:16:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 856183858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680585380; x=1712121380; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ZQ/hvfntFq1+qgNQCJp7ON8i4OBjXYr4K/2DX/0oTwg=; b=SY523lK0KZ7SESe53fVom777FKCcwXockizfDI2vx/WQet3QbJL5y/D0 8Os7dJbTq63hJw7CyzwRz8udk+tK0nHZ+1mx21Rnn/onICdqpdu4BIrzl hZfdT3VawjFmu51NUBzN1Swdz0xsCGAQgUdFcRLaMiu06aaETj803bVMW 2ziEMjWWF0XYCMMbUoqXf200K6z+F4zEuNThsXdHp1ergpF6YoagcGkjv QE7Hwj/F4eMwRrNdsy63gKb1y29RhNBh+8YScAhjhPfpgRUTZbUgb2Jv9 ayjTc9s0zaRKuiVWvRFujKLno2Rl5u3wPVumofQquR92ArtMuCB/ussfC Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="407151901" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="407151901" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2023 22:15:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="810093163" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="810093163" Received: from shvmail03.sh.intel.com ([10.239.245.20]) by orsmga004.jf.intel.com with ESMTP; 03 Apr 2023 22:15:47 -0700 Received: from shliclel4217.sh.intel.com (shliclel4217.sh.intel.com [10.239.240.127]) by shvmail03.sh.intel.com (Postfix) with ESMTP id 78B5810079CD; Tue, 4 Apr 2023 13:15:46 +0800 (CST) From: liuhongt To: gcc-patches@gcc.gnu.org Cc: vmakarov@redhat.com Subject: [PATCH] Check hard_regno_mode_ok before setting lowest memory move cost for the mode with different reg classes. Date: Tue, 4 Apr 2023 13:13:46 +0800 Message-Id: <20230404051346.1223071-1-hongtao.liu@intel.com> X-Mailer: git-send-email 2.39.1.388.g2fc9e9ca3c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: There's a potential performance issue when backend returns some unreasonable value for the mode which can be never be allocate with reg class. Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. Ok for trunk(or GCC14 stage1)? gcc/ChangeLog: PR rtl-optimization/109351 * ira.cc (setup_class_subset_and_memory_move_costs): Check hard_regno_mode_ok before setting lowest memory move cost for the mode with different reg classes. --- gcc/ira.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gcc/ira.cc b/gcc/ira.cc index 6c7f4901e4c..02dea5d49ee 100644 --- a/gcc/ira.cc +++ b/gcc/ira.cc @@ -588,6 +588,10 @@ setup_class_subset_and_memory_move_costs (void) /* Costs for NO_REGS are used in cost calculation on the 1st pass when the preferred register classes are not known yet. In this case we take the best scenario. */ + if (!targetm.hard_regno_mode_ok (ira_class_hard_regs[cl][0], + (machine_mode) mode)) + continue; + if (ira_memory_move_cost[mode][NO_REGS][0] > ira_memory_move_cost[mode][cl][0]) ira_max_memory_move_cost[mode][NO_REGS][0] -- 2.39.1.388.g2fc9e9ca3c