From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 494E4388F94C for ; Wed, 5 Apr 2023 14:22:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 494E4388F94C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 335ELfVD008014; Wed, 5 Apr 2023 09:21:41 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 335ELfOL008008; Wed, 5 Apr 2023 09:21:41 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Wed, 5 Apr 2023 09:21:40 -0500 From: Segher Boessenkool To: Jeff Law Cc: "gcc-patches@gcc.gnu.org" Subject: Re: [RFA][Bug target/108892 ][13 regression] Force re-recognition after changing RTL structure of an insn Message-ID: <20230405142140.GH25951@gate.crashing.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On Wed, Mar 29, 2023 at 07:48:00AM -0600, Jeff Law wrote: > So as mentioned in the PR the underlying issue here is combine changes > the form of an existing insn, but fails to force re-recognition. As a > result other parts of the compiler blow up. [snip] > The fix is trivial, reset the INSN_CODE to force re-recognition in the > case where try_combine fails. Thanks for the clear explanation! Okay for trunk. Also okay for all backports (after a week or so on trunk). > * combine.cc (combine_instructions): Force re-recognition when > potentially changing the underlying RTL structure of an insn. When returning the original, might be clearer? Thanks, Segher