From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C85393858D32 for ; Wed, 12 Apr 2023 13:45:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C85393858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681307107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cap4NtRSEc1OMpgnx6z1DXsi8efdQuiVoF+qGwFwG+I=; b=MGtX1ei5ZNv575FlF6jlrRfR2vQ85WFqjgI3aQSW7nnSmGfoq2niCITjplhREYYpSuP+iD 794+sif1Xnv1KEPlw3Seb2Q/QWJoHCFdnrYFR3ViOFdI/LgeQUHDk5jAvJFsLX2Hgu2Bnb pJFBqWodjJAmdRpcE7xnacW0znhismE= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-30-EjpZ1tY9Oc6NmgotEo4Bpg-1; Wed, 12 Apr 2023 09:45:06 -0400 X-MC-Unique: EjpZ1tY9Oc6NmgotEo4Bpg-1 Received: by mail-qt1-f197.google.com with SMTP id e3-20020ac84e43000000b003e259c363f9so8921068qtw.22 for ; Wed, 12 Apr 2023 06:45:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681307105; x=1683899105; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cap4NtRSEc1OMpgnx6z1DXsi8efdQuiVoF+qGwFwG+I=; b=G2CnyPV79t2DnSw4ausD9zS5d6V4cErQQCM11dpoNXuV2iFm8cjWvdI1JbxekaPJcy 8l3K320BORfqVE2ZkATV+ToLIIs+vqnPj69r0CTVfBZkUbgjWwRdwnRi0GSR63EBJ0UU 1jsFjb3/xE+LTIr/X12ZOYl1F0257GTPmE6OVzQKvbp7MDZ534KxfrcZHY+q3puAbdwz bBOhBEs8orX6Lev1zGIqHH0IcdK/2Xkjilh7IteDfRU5tg+NeArqWb/48ba9TWT9HBOo wo5F3quLrlz+HICa2gq66go3t9gt0jJEGqUSd5riyWM4oN8ZP1ahQMQe4fCuPS1gtF9+ Z9tQ== X-Gm-Message-State: AAQBX9c39rObXtRrHgfOlI6/2TqR3aS7AVtGZRq/8pDO9GwzdmwkZpEn 1R3ytSppvEHR/tMDIO1A4dagG0rMffzr5MbQswe1Is20CFLVU8eOwQ5zvwAVA20HmMSltRhNGcq 5Hc6LiqhzYrQUw+sxsXJb7Ye/lC2Uou/b9yDKoSbSMgfkTOWgCUo0QDBGnCHwrvU3n3FLZ5FwKW o= X-Received: by 2002:a05:622a:2d4:b0:3e6:469b:85df with SMTP id a20-20020a05622a02d400b003e6469b85dfmr3500715qtx.18.1681307105578; Wed, 12 Apr 2023 06:45:05 -0700 (PDT) X-Google-Smtp-Source: AKy350a+rIp9RR/3WT6XsMK6tpM4Vpt+ff/k6Mz80lewsn29tIvr0wkrSz7IBxrNctcA/8gd1M8Hzw== X-Received: by 2002:a05:622a:2d4:b0:3e6:469b:85df with SMTP id a20-20020a05622a02d400b003e6469b85dfmr3500682qtx.18.1681307105256; Wed, 12 Apr 2023 06:45:05 -0700 (PDT) Received: from localhost.localdomain (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id c24-20020ac85198000000b003e3c23dd2cfsm4262934qtn.84.2023.04.12.06.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 06:45:04 -0700 (PDT) From: Patrick Palka To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Patrick Palka Subject: [PATCH] libstdc++: Ensure headers used by fast_float are included Date: Wed, 12 Apr 2023 09:45:02 -0400 Message-Id: <20230412134502.3147419-1-ppalka@redhat.com> X-Mailer: git-send-email 2.40.0.315.g0607f793cb MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This makes floating_from_chars.cc explicitly include all headers that are used by the original fast_float amalgamation according to r12-6647-gf5c8b82512f9d3, except: 1. since fast_float doesn't seem to use anything from it 2. since fast_float doesn't seem to use anything directly from it (as opposed to from ) 3. since std::errc is naturally already available from This avoids potential build failures on platforms for which some required headers (namely ) end up not getting transitively included from elsewhere. Tested on x86_64-pc-linux-gnu, does this look OK for trunk/12? libstdc++-v3/ChangeLog: * src/c++17/floating_from_chars.cc: Include , , and . --- libstdc++-v3/src/c++17/floating_from_chars.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libstdc++-v3/src/c++17/floating_from_chars.cc b/libstdc++-v3/src/c++17/floating_from_chars.cc index 5d18ca32dbb..3a411cf546a 100644 --- a/libstdc++-v3/src/c++17/floating_from_chars.cc +++ b/libstdc++-v3/src/c++17/floating_from_chars.cc @@ -30,14 +30,18 @@ // Prefer to use std::pmr::string if possible, which requires the cxx11 ABI. #define _GLIBCXX_USE_CXX11_ABI 1 +#include #include #include #include +#include +#include #include #include #include #include #include +#include #include #include #include -- 2.40.0.315.g0607f793cb