public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Richard Biener <rguenther@suse.de>
Cc: Jiufu Guo <guojiufu@linux.ibm.com>,
	gcc-patches@gcc.gnu.org, dmalcolm@redhat.com,
	jeffreyalaw@gmail.com, dje.gcc@gmail.com, linkw@gcc.gnu.org,
	meissner@linux.ibm.com
Subject: Re: [PATCH] testsuite: filter out warning noise for CWE-1341 test
Date: Thu, 13 Apr 2023 07:08:52 -0500	[thread overview]
Message-ID: <20230413120852.GF19790@gate.crashing.org> (raw)
In-Reply-To: <nycvar.YFH.7.77.849.2304130734230.4466@jbgna.fhfr.qr>

On Thu, Apr 13, 2023 at 07:39:01AM +0000, Richard Biener wrote:
> On Thu, 13 Apr 2023, Jiufu Guo wrote:
> I think this should be fixed in the analyzer, "stripping" malloc
> tracking from fopen/fclose since it does this manually.  I've adjusted
> the bug accordingly.

Yeah.

> > > +/* This case checks double-fclose only, suppress other warning.  */
> > > +/* { dg-additional-options -Wno-analyzer-double-free } */

So please add "(PR108722)" or such to the comment here?  That is enough
for future people to see if this is still necessary, to maybe remove it
from the testcase here, but certainly not cargo-cult it to other
testcases!

Thanks,


Segher

  reply	other threads:[~2023-04-13 12:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12  6:08 Jiufu Guo
2023-04-13  5:07 ` Jiufu Guo
2023-04-13  7:39   ` Richard Biener
2023-04-13 12:08     ` Segher Boessenkool [this message]
2023-04-14  3:13       ` guojiufu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230413120852.GF19790@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=dje.gcc@gmail.com \
    --cc=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=guojiufu@linux.ibm.com \
    --cc=jeffreyalaw@gmail.com \
    --cc=linkw@gcc.gnu.org \
    --cc=meissner@linux.ibm.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).