From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 17DE33858D20 for ; Fri, 14 Apr 2023 09:45:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17DE33858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 298361FD95 for ; Fri, 14 Apr 2023 09:45:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681465525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=W3j1+lMYc/GCK8JZJX7X2NlA4lpKZKjzWXQo2uAikuY=; b=h2ms4cwfWrpN7FGVopMYl2w5AZywxrxHSB4+9ef9Y+H+de10AgGCLmk3YBvuiRHVnTyHAY AqV51fz0rwg4vUvq40ztPKJ2T1X2c3RwEmqpmuykTt3fcmlvs2XpKoS4h2aueM9Mpyy3ts kjtvEmkqm9ZuG66sYF8xDonYiQkXCPQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681465525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=W3j1+lMYc/GCK8JZJX7X2NlA4lpKZKjzWXQo2uAikuY=; b=I/nYHw7sF5RztHFNlOpZKWgaxk82eu8toHkvlN2Zi/0Aqw3at9bn/NQQ6hcuDyAW0fxJJg 4nYPdeUgiARbV7DA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1645E13498 for ; Fri, 14 Apr 2023 09:45:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ouchBLUgOWSFEgAAMHmgww (envelope-from ) for ; Fri, 14 Apr 2023 09:45:25 +0000 Date: Fri, 14 Apr 2023 11:45:24 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/109502 - vector conversion between mask and non-mask MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Message-Id: <20230414094525.1645E13498@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The following fixes a check that should have rejected vectorizing a conversion between a mask and non-mask type. Those should be done via pattern statements. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/109502 * tree-vect-stmts.cc (vectorizable_assignment): Fix check for conversion between mask and non-mask types. * gcc.dg/vect/pr109502.c: New testcase. --- gcc/testsuite/gcc.dg/vect/pr109502.c | 21 +++++++++++++++++++++ gcc/tree-vect-stmts.cc | 3 +-- 2 files changed, 22 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/vect/pr109502.c diff --git a/gcc/testsuite/gcc.dg/vect/pr109502.c b/gcc/testsuite/gcc.dg/vect/pr109502.c new file mode 100644 index 00000000000..970c63e931b --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/pr109502.c @@ -0,0 +1,21 @@ +/* { dg-do run } */ +/* { dg-additional-options "-O" } */ + +unsigned g; + +unsigned +foo (void) +{ + unsigned a = !g; + a += !(a % 6); + return a; +} + +int +main () +{ + unsigned x = foo (); + if (x != 1) + __builtin_abort (); + return 0; +} diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index efa2d0daa52..6b7dbfd4a23 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -5595,8 +5595,7 @@ vectorizable_assignment (vec_info *vinfo, GET_MODE_SIZE (TYPE_MODE (vectype_in))))) return false; - if (VECTOR_BOOLEAN_TYPE_P (vectype) - && !VECTOR_BOOLEAN_TYPE_P (vectype_in)) + if (VECTOR_BOOLEAN_TYPE_P (vectype) != VECTOR_BOOLEAN_TYPE_P (vectype_in)) { if (dump_enabled_p ()) dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location, -- 2.35.3