From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id BBBE13858CDA for ; Wed, 19 Apr 2023 20:01:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BBBE13858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 33JK0CCT032197; Wed, 19 Apr 2023 15:00:12 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 33JK0CuM032196; Wed, 19 Apr 2023 15:00:12 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Wed, 19 Apr 2023 15:00:11 -0500 From: Segher Boessenkool To: Ajit Agarwal Cc: gcc-patches , jeff Law , Peter Bergner , jakub Jelinek , Richard Biener Subject: Re: [PATCH v3 1/4] ree: Default ree pass for O2 and above for rs6000 target. Message-ID: <20230419200011.GG19790@gate.crashing.org> References: <236aab6b-537f-7fb6-125c-220fb63f7521@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <236aab6b-537f-7fb6-125c-220fb63f7521@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! The subject should be something like rs6000: Enable REE pass by default (and no period at the end). On Wed, Apr 19, 2023 at 11:23:07PM +0530, Ajit Agarwal wrote: > This is the patch-1 for improving ree pass for rs6000 target. It actually just enables it :-) The mail body should be the proposed commit message. Nothing more, nothing less. If you need (or want) to talk about more things, that is what a "0/4" message is for (you create that with --cover). Your patch messages here do not thread properly, how did you create them? Things work fine if you use git format-patch --thread :-) > ree: Improve ree pass for rs6000 target. > > Add ree pass as a default pass for rs6000 target. > > 2023-04-19 Ajit Kumar Agarwal You aren't in MAINTAINERS yet, please fix that first! > > gcc/ChangeLog: > > * common/config/rs6000/rs6000-common.cc: Add REE pass as a > default rs6000 target pass for O2 and above. Why only for -O2? Only when optimising at all makes sense, people use -O0 only when they want to skip as many optimisations as possible, maybe because of compilation time concerns, maybe to avoid an ICE or other bug. Isn't REE *always* a good thing, it never degrades code quality? Or are there situations where it results in worse code? Segher