From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 772FF3858D1E for ; Tue, 25 Apr 2023 06:25:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 772FF3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AAA0A1FDA5; Tue, 25 Apr 2023 06:25:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682403943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=qQjj1/IsqJH4gm8xXms6WaKjefGrM1PGYMmmX5b6IQ0=; b=KvhITf177RwFjrtq+P/J+5SmyNmGfGTW8tfrE61uFLua1ZSPvMVUwAP54vT2o3JbezFlro XbEBrBCi3kVJ1aFDMobHOkDTGxGLMfkOwTDgBKwhXg58sosCaWerhnN3oKqOVMbd5CVZO6 PZbipAIxeRaFnfidNIF3LofIGEsjmXg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682403943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=qQjj1/IsqJH4gm8xXms6WaKjefGrM1PGYMmmX5b6IQ0=; b=eqN4E7X8nSbN6/7iQtAATmUx8PxhjiO5zRPFK8TBG4Kp2IZGn7qbAdddjQhF1hdkTGCBX5 R2EEOlab+TViw5DA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 851AF13466; Tue, 25 Apr 2023 06:25:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lt1AH2dyR2SdGgAAMHmgww (envelope-from ); Tue, 25 Apr 2023 06:25:43 +0000 Date: Tue, 25 Apr 2023 08:25:43 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: Jan Hubicka Subject: [PATCH] rtl-optimization/109585 - alias analysis typo MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Message-Id: <20230425062543.851AF13466@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When r10-514-gc6b84edb6110dd2b4fb improved access path analysis it introduced a typo that triggers when there's an access to a trailing array in the first access path leading to false disambiguation. Bootstrapped and tested on x86_64-unknown-linux-gnu. Honza, does this look OK? Thanks, Richard. PR rtl-optimization/109585 * tree-ssa-alias.cc (aliasing_component_refs_p): Fix typo. * gcc.dg/torture/pr109585.c: New testcase. --- gcc/testsuite/gcc.dg/torture/pr109585.c | 33 +++++++++++++++++++++++++ gcc/tree-ssa-alias.cc | 2 +- 2 files changed, 34 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/torture/pr109585.c diff --git a/gcc/testsuite/gcc.dg/torture/pr109585.c b/gcc/testsuite/gcc.dg/torture/pr109585.c new file mode 100644 index 00000000000..f92de7c1f2e --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr109585.c @@ -0,0 +1,33 @@ +/* { dg-do run } */ + +#include + +struct P { + long v; + struct P *n; +}; + +struct F { + long x; + struct P fam[]; +}; + +int __attribute__((noipa)) +f(struct F *f, int i) +{ + struct P *p = f->fam; + asm("" : "+r"(f): "r"(p)); + p->v = 0; + p->n = 0; + return f->fam->n != 0; +} + +int +main() +{ + struct F *m = malloc (sizeof (long) + 2 * sizeof (struct P)); + m->fam[0].n = &m->fam[1]; + if (f (m, 0)) + abort (); + return 0; +} diff --git a/gcc/tree-ssa-alias.cc b/gcc/tree-ssa-alias.cc index 81bc51ed4ad..8a1ec9091fa 100644 --- a/gcc/tree-ssa-alias.cc +++ b/gcc/tree-ssa-alias.cc @@ -1330,7 +1330,7 @@ aliasing_component_refs_p (tree ref1, /* If we didn't find a common base, try the other way around. */ if (cmp_outer <= 0 || (end_struct_ref1 - && compare_type_sizes (TREE_TYPE (end_struct_ref1), type1) <= 0)) + && compare_type_sizes (TREE_TYPE (end_struct_ref1), type2) <= 0)) { int res = aliasing_component_refs_walk (ref2, type2, base2, offset2, max_size2, -- 2.35.3