public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Jiufu Guo <guojiufu@linux.ibm.com>
Cc: gcc-patches@gcc.gnu.org, rguenther@suse.de,
	jeffreyalaw@gmail.com, dje.gcc@gmail.com, linkw@gcc.gnu.org,
	meissner@linux.ibm.com
Subject: Re: [PATCH V5] Use reg mode to move sub blocks for parameters and returns
Date: Mon, 1 May 2023 10:52:28 -0500	[thread overview]
Message-ID: <20230501155228.GY19790@gate.crashing.org> (raw)
In-Reply-To: <20230317033952.1549050-1-guojiufu@linux.ibm.com>

Hi!

On Fri, Mar 17, 2023 at 11:39:52AM +0800, Jiufu Guo wrote:
> gcc/testsuite/ChangeLog:
> 
> 	* gcc.target/powerpc/pr65421-1.c: New test.
> 	* gcc.target/powerpc/pr65421.c: New test.

Please name the tests something else?  -1.c and -2.c maybe.  Or
something more inspired.  Just not something that makes the less
important of the (so far) two testcases look more important than it is.

The testcases are fine otherwise, thanks!


Segher

  parent reply	other threads:[~2023-05-01 15:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17  3:39 Jiufu Guo
2023-04-30 19:00 ` Jeff Law
2023-05-04  5:49   ` guojiufu
2023-05-05 23:37     ` Jeff Law
2023-05-09 13:43       ` Jiufu Guo
2023-06-04 16:59         ` Jeff Law
2023-06-07  1:21           ` guojiufu
2023-05-01 15:52 ` Segher Boessenkool [this message]
2023-05-04  5:55   ` guojiufu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230501155228.GY19790@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=guojiufu@linux.ibm.com \
    --cc=jeffreyalaw@gmail.com \
    --cc=linkw@gcc.gnu.org \
    --cc=meissner@linux.ibm.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).