From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] tree-optimization/109672 - properly check emulated plus during vect
Date: Tue, 2 May 2023 09:56:28 +0000 (UTC) [thread overview]
Message-ID: <20230502095628.pS91JCn_zFPfG7eTuHIbRjtKUakKDkbpHMzp_CkF6Vw@z> (raw)
The following refactors the check for emulated vector support for
the cases of plus, minus and negate. In the PR we end up with
a SImode plus, supported by the target but emulated and in this
context fail to verify we are dealing with exactly word_mode.
Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.
PR tree-optimization/109672
* tree-vect-stmts.cc (vectorizable_operation): For plus,
minus and negate always check the vector mode is word mode.
---
gcc/tree-vect-stmts.cc | 21 +++++++++------------
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc
index c71e28737ee..3ad6a7d28d7 100644
--- a/gcc/tree-vect-stmts.cc
+++ b/gcc/tree-vect-stmts.cc
@@ -6384,29 +6384,26 @@ vectorizable_operation (vec_info *vinfo,
}
bool using_emulated_vectors_p = vect_emulated_vector_p (vectype);
- if (!target_support_p)
+ if (!target_support_p || using_emulated_vectors_p)
{
if (dump_enabled_p ())
dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location,
- "op not supported by target.\n");
+ "op not supported by target.\n");
/* Check only during analysis. */
- if (maybe_ne (GET_MODE_SIZE (vec_mode), UNITS_PER_WORD)
+ if (((code == PLUS_EXPR || code == MINUS_EXPR || code == NEGATE_EXPR)
+ && maybe_ne (GET_MODE_SIZE (vec_mode), UNITS_PER_WORD))
|| (!vec_stmt && !vect_can_vectorize_without_simd_p (code)))
- return false;
+ {
+ if (dump_enabled_p ())
+ dump_printf (MSG_NOTE, "using word mode not possible.\n");
+ return false;
+ }
if (dump_enabled_p ())
dump_printf_loc (MSG_NOTE, vect_location,
"proceeding using word mode.\n");
using_emulated_vectors_p = true;
}
- if (using_emulated_vectors_p
- && !vect_can_vectorize_without_simd_p (code))
- {
- if (dump_enabled_p ())
- dump_printf (MSG_NOTE, "using word mode not possible.\n");
- return false;
- }
-
int reduc_idx = STMT_VINFO_REDUC_IDX (stmt_info);
vec_loop_masks *masks = (loop_vinfo ? &LOOP_VINFO_MASKS (loop_vinfo) : NULL);
internal_fn cond_fn = get_conditional_internal_fn (code);
--
2.35.3
reply other threads:[~2023-05-02 9:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230502095628.pS91JCn_zFPfG7eTuHIbRjtKUakKDkbpHMzp_CkF6Vw@z \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).