From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id E5199385277D for ; Mon, 15 May 2023 09:43:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E5199385277D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f42d937d61so63007875e9.3 for ; Mon, 15 May 2023 02:43:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1684143828; x=1686735828; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AwNd/po6vaYCdjJe4l5d8tYGKYMT0YwoJPf7Gep9cXA=; b=XgSDFkOB10UUbJnaukH8/1lD+xKI7OjUPEx23vyKWzTLQef2XOD8r4OjgIOAv0YGid r0zbeSj72UzG6ehtApI2T/MH9EEYuFWLmuIH3JFZ9CtjJAFVcJ2aTS/b6AigyZRdCW15 zf/NZbO34Thy0JbEzrAgU7uBXXG0HlpGwwncyRCi9+hxS29oeeJ+Q1lvNhhRaB30klId 6sKpZR6asElAYQFGZDAgQ/4VhocC/BR74Yzk9OzOysPNFse9LdqanHSeP7RhKZOtnbh0 LcsIdWDfaMGQuLZ1G/jVbPfVlV4Lvt/3IAEoVNyUWMdUHnmy6/YLydSU6ru6640+R8xy jN7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684143828; x=1686735828; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AwNd/po6vaYCdjJe4l5d8tYGKYMT0YwoJPf7Gep9cXA=; b=ce68XaLpcdN4xUqyq1IgbeGmxPLybHXLBjXEgmc4FAbPplV4cpuIeBXJdSUzjNATJY k55AGfxAQDk6/Edxv2Erw5XOgMhklT1s5PCqd9R7f6g/97TQpvR16ro09jivJab6ZFU3 HagfK2MLeJlfptMYBeR9O9WO7I3Q3nozAQDconRyY8QTgjcieNZbIbscByNPqUS64v1Z uqsc90NWrt+QJJZkNwqjG8zWA5KWvbMuHC+NGAtiqt39SfB9Iclf6AbGWlR9RtMXi/pl 9QKkVMOg7dq+BQiw78AQnFFtDetF0vLodxEEHJdNNIUJ9jYkGn3O1d4JS93rZruiUPTg kD0A== X-Gm-Message-State: AC+VfDxUzOZLJlkqebthnpDClMn0eFcI5BhzTRsUCt3vJdrRhKJxH2WE vI+ADnyqB7sGZKcO5NseBdS90lLKJxzNwpYXAGlt3w== X-Google-Smtp-Source: ACHHUZ6Ue+ob3Yf/pdLk9cxASFyG5uNvhQ3hAQ5EC5iiAkic5oGuFK2OXQxey1inqO99PBHjNz1MpQ== X-Received: by 2002:a05:600c:b47:b0:3f5:bc8:e398 with SMTP id k7-20020a05600c0b4700b003f50bc8e398mr1699646wmr.13.1684143828739; Mon, 15 May 2023 02:43:48 -0700 (PDT) Received: from poulhies-Precision-5550.telnowedge.local (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id m16-20020a7bca50000000b003f1957ace1fsm36333083wml.13.2023.05.15.02.43.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 02:43:48 -0700 (PDT) From: =?UTF-8?q?Marc=20Poulhi=C3=A8s?= To: gcc-patches@gcc.gnu.org Cc: Piotr Trojanek Subject: [COMMITTED] ada: Remove redundant protection against empty lists Date: Mon, 15 May 2023 11:43:46 +0200 Message-Id: <20230515094346.1408423-1-poulhies@adacore.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Piotr Trojanek Calls to First on No_List intentionally return Empty node, so explicit guards against No_List are unnecessary. Code cleanup; semantics is unaffected. gcc/ada/ * sem_util.adb (New_Copy_Tree): Remove redundant calls to Present. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/sem_util.adb | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/gcc/ada/sem_util.adb b/gcc/ada/sem_util.adb index 5ec0140d090..eb0d08a1851 100644 --- a/gcc/ada/sem_util.adb +++ b/gcc/ada/sem_util.adb @@ -24167,14 +24167,12 @@ package body Sem_Util is -- Note that the element of a syntactic list is always a node, never -- an entity or itype, hence the call to Visit_Node. - if Present (List) then - Elmt := First (List); - while Present (Elmt) loop - Visit_Node (Elmt); + Elmt := First (List); + while Present (Elmt) loop + Visit_Node (Elmt); - Next (Elmt); - end loop; - end if; + Next (Elmt); + end loop; end Visit_List; ---------------- @@ -24206,8 +24204,7 @@ package body Sem_Util is -- If the node is a block, we need to process all declarations -- in the block and make new entities for each. - if Nkind (N) = N_Block_Statement and then Present (Declarations (N)) - then + if Nkind (N) = N_Block_Statement then declare Decl : Node_Id := First (Declarations (N)); -- 2.40.0