From: "Marc Poulhiès" <poulhies@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Javier Miranda <miranda@adacore.com>
Subject: [COMMITTED] ada: Spurious error on function returning CPP type
Date: Tue, 16 May 2023 10:41:03 +0200 [thread overview]
Message-ID: <20230516084103.1502006-1-poulhies@adacore.com> (raw)
From: Javier Miranda <miranda@adacore.com>
gcc/ada/
* exp_ch6.adb
(Needs_BIP_Alloc_Form): Return False for functions with foreign
convention since we never use build-in-place for such functions.
Tested on x86_64-pc-linux-gnu, committed on master.
---
gcc/ada/exp_ch6.adb | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/gcc/ada/exp_ch6.adb b/gcc/ada/exp_ch6.adb
index af7f75342fa..b8e5a720a7c 100644
--- a/gcc/ada/exp_ch6.adb
+++ b/gcc/ada/exp_ch6.adb
@@ -9435,9 +9435,14 @@ package body Exp_Ch6 is
-- types, and those can be used to call primitives, so the formal needs
-- to be passed to all such build-in-place functions, primitive or not.
+ -- We never use build-in-place if the function has foreign convention,
+ -- but note that it is OK for a build-in-place function to return a
+ -- type with a foreign convention because the machinery ensures there
+ -- is no copying.
+
return not Restriction_Active (No_Secondary_Stack)
and then (Needs_Secondary_Stack (Typ) or else Is_Tagged_Type (Typ))
- and then not Has_Foreign_Convention (Typ);
+ and then not Has_Foreign_Convention (Func_Id);
end Needs_BIP_Alloc_Form;
-------------------------------------
--
2.40.0
reply other threads:[~2023-05-16 8:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230516084103.1502006-1-poulhies@adacore.com \
--to=poulhies@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=miranda@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).