From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id E5DC53857027; Thu, 18 May 2023 19:53:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E5DC53857027 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-510d1972d5aso3414041a12.0; Thu, 18 May 2023 12:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684439595; x=1687031595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=B4cifpcRQZGYFyerSqDOIMerdM8namA+wDi/IZXe58A=; b=GRMC/kHOiHZ7L3/4hnZf2YXIU5JW+5kzczHuAhOOhumRa4CdoypNxFxNqEugvNqDa4 XTTnV06ptBA3zorzNfp6ReXceryXpMIH2st6LWUa3xgxBOCDn7Wg/ebZiR6WjlJifYiQ MkA8OXmFC9qJ1v0+1MJF8DCWgz7uZTudF/Keyz8XAbaG1SdqvbCT6uHti8kA48srMcH9 BGKfEhRjrYssZqKdCTzJJfze28Iga/m3sBP3GuR+yjAAi58ajD4inIk8BWgNIz/TkNd9 e/kaBD9A781MI4QNl0/ew45B/7NbBtj/ZR+lIG3QFc4NeFHbjW+h9qcsCkDLNw2wo7TE CnDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684439595; x=1687031595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B4cifpcRQZGYFyerSqDOIMerdM8namA+wDi/IZXe58A=; b=kPGyiI+bn6kTNy67ypIX6xDcb9OQZ7h1/GDCJ0FyhKzNAw9OE+9vHURs67H1V/imUO 5N/0pczW7hhv9ouW5yvSBK6aNdXr1xFCMTbH5+L57/8114XWj7NGSEKzAlI0pSNOSEQd Dr+AjNKzhMZCFVwAOwmKncMXbimWwsTPAwrLh9qVXZPBpyb8EX3mbJzm2M3kzwjhGtOD HBmcHhrpHHOee2iCWU8IHceoCQVy3G7mSD4DQEte9Oc6rRwtpMAOv7JAqSZ0++ZX/B9w 8pNXMW6UIZKDxRIJeycdbxbRzvtic+uOId5BwraSuFILOIbR26SYkV1AQK8dwYeA8Xbh 0Bpw== X-Gm-Message-State: AC+VfDx9bNk9iVFUUw1/u4fTEnJ59mtI8x/3xmbhMMXV87tFdWIc+TRm OxsCJVXwyqQj84Om9HaRL0ZozbSEVbc= X-Google-Smtp-Source: ACHHUZ6cNWZ1KUXMrL9WH2/GBwM4ey0tcmLIBiyCJrx6ODxDH1iEiLRLP/VsJdIevimIEZfYyd/8Gw== X-Received: by 2002:a05:6402:5170:b0:50b:c584:527b with SMTP id d16-20020a056402517000b0050bc584527bmr6037108ede.29.1684439595064; Thu, 18 May 2023 12:53:15 -0700 (PDT) Received: from nbbrfq.loc (80-110-214-113.static.upcbusiness.at. [80.110.214.113]) by smtp.gmail.com with ESMTPSA id t4-20020aa7d704000000b00510d6795eddsm894407edq.48.2023.05.18.12.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 12:53:14 -0700 (PDT) Date: Thu, 18 May 2023 21:53:10 +0200 From: Bernhard Reutner-Fischer To: Eric Botcazou Cc: Bernhard Reutner-Fischer , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 01/14] ada: use _P() defines from tree.h Message-ID: <20230518215310.7dd51c8c@nbbrfq.loc> In-Reply-To: <3235564.44csPzL39Z@fomalhaut> References: <20230513232321.279733-1-rep.dot.nop@gmail.com> <20230513232321.279733-2-rep.dot.nop@gmail.com> <3235564.44csPzL39Z@fomalhaut> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 15 May 2023 12:05:10 +0200 Eric Botcazou wrote: > > && DECL_RETURN_VALUE_P (inner)) > > diff --git a/gcc/ada/gcc-interface/utils.cc b/gcc/ada/gcc-interface/utils.cc > > index 0c4f8b90c8e..460ef6f1f01 100644 > > --- a/gcc/ada/gcc-interface/utils.cc > > +++ b/gcc/ada/gcc-interface/utils.cc > > @@ -1966,7 +1966,7 @@ finish_record_type (tree record_type, tree field_list, > > int rep_level, bool debug_info_p) > > { > > const enum tree_code orig_code = TREE_CODE (record_type); > > - const bool had_size = TYPE_SIZE (record_type) != NULL_TREE; > > + const bool had_size = COMPLETE_TYPE_P (record_type); > > const bool had_align = TYPE_ALIGN (record_type) > 0; > > /* For all-repped records with a size specified, lay the QUAL_UNION_TYPE > > out just like a UNION_TYPE, since the size will be fixed. */ > > This one is not an improvement but more of a coincidence; the rest is OK. > I've dropped this hunk and installed the rest as r14-974-g04682fe764004b. Thanks!