From: Andrew Pinski <apinski@marvell.com>
To: <gcc-patches@gcc.gnu.org>
Cc: Andrew Pinski <apinski@marvell.com>
Subject: [PATCH 2/2] Improve do_store_flag for comparing single bit against that bit
Date: Thu, 18 May 2023 19:14:10 -0700 [thread overview]
Message-ID: <20230519021410.1841811-2-apinski@marvell.com> (raw)
In-Reply-To: <20230519021410.1841811-1-apinski@marvell.com>
This is a case which I noticed while working on the previous patch.
Sometimes we end up with `a == CST` instead of comparing against 0.
This happens in the following code:
```
unsigned f(unsigned t)
{
if (t & ~(1<<30)) __builtin_unreachable();
t ^= (1<<30);
return t != 0;
}
```
We should handle the case where the nonzero bits is the same as the
comparison operand.
OK? Bootstrapped and tested on x86_64-linux-gnu.
gcc/ChangeLog:
* expr.cc (do_store_flag): Improve for single bit testing
not against zero but against that single bit.
---
gcc/expr.cc | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/gcc/expr.cc b/gcc/expr.cc
index 91528e734e7..a4628c51c0c 100644
--- a/gcc/expr.cc
+++ b/gcc/expr.cc
@@ -13080,12 +13080,15 @@ do_store_flag (sepops ops, rtx target, machine_mode mode)
so we just call into the folder and expand its result. */
if ((code == NE || code == EQ)
- && integer_zerop (arg1)
+ && (integer_zerop (arg1)
+ || integer_pow2p (arg1))
&& (TYPE_PRECISION (ops->type) != 1 || TYPE_UNSIGNED (ops->type)))
{
wide_int nz = tree_nonzero_bits (arg0);
- if (wi::popcount (nz) == 1)
+ if (wi::popcount (nz) == 1
+ && (integer_zerop (arg1)
+ || wi::to_wide (arg1) == nz))
{
tree op0;
tree op1;
@@ -13103,11 +13106,13 @@ do_store_flag (sepops ops, rtx target, machine_mode mode)
op0 = arg0;
op1 = wide_int_to_tree (TREE_TYPE (op0), nz);
}
- enum tree_code tcode = code == NE ? NE_EXPR : EQ_EXPR;
+ enum tree_code tcode = EQ_EXPR;
+ if ((code == NE) ^ !integer_zerop (arg1))
+ tcode = NE_EXPR;
type = lang_hooks.types.type_for_mode (mode, unsignedp);
tree temp = fold_build2_loc (loc, BIT_AND_EXPR, TREE_TYPE (op0),
op0, op1);
- temp = fold_single_bit_test (loc, tcode, temp, arg1, type);
+ temp = fold_single_bit_test (loc, tcode, temp, build_zero_cst (type), type);
if (temp)
return expand_expr (temp, target, VOIDmode, EXPAND_NORMAL);
}
--
2.31.1
next prev parent reply other threads:[~2023-05-19 2:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 2:14 [PATCH 1/2] Improve do_store_flag for single bit comparison against 0 Andrew Pinski
2023-05-19 2:14 ` Andrew Pinski [this message]
2023-05-19 16:45 ` [PATCH 2/2] Improve do_store_flag for comparing single bit against that bit Jeff Law
2023-05-19 16:38 ` [PATCH 1/2] Improve do_store_flag for single bit comparison against 0 Jeff Law
2023-05-19 22:04 ` Andrew Pinski
2023-05-22 11:55 ` Richard Biener
2023-05-22 15:21 ` Andrew Pinski
2023-05-23 6:07 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230519021410.1841811-2-apinski@marvell.com \
--to=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).