From: Andrew Pinski <apinski@marvell.com>
To: <gcc-patches@gcc.gnu.org>
Cc: Andrew Pinski <apinski@marvell.com>
Subject: [PATCH 6/7] Use BIT_FIELD_REF inside fold_single_bit_test
Date: Fri, 19 May 2023 19:14:50 -0700 [thread overview]
Message-ID: <20230520021451.1901275-7-apinski@marvell.com> (raw)
In-Reply-To: <20230520021451.1901275-1-apinski@marvell.com>
Instead of depending on combine to do the extraction,
Let's create a tree which will expand directly into
the extraction. This improves code generation on some
targets.
OK? Bootstrapped and tested on x86_64-linux.
gcc/ChangeLog:
* expr.cc (fold_single_bit_test): Use BIT_FIELD_REF
instead of shift/and.
---
gcc/expr.cc | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/gcc/expr.cc b/gcc/expr.cc
index b5bc3fabb7e..d04e8ed0204 100644
--- a/gcc/expr.cc
+++ b/gcc/expr.cc
@@ -12957,22 +12957,21 @@ fold_single_bit_test (location_t loc, enum tree_code code,
intermediate_type = ops_unsigned ? unsigned_type : signed_type;
inner = fold_convert_loc (loc, intermediate_type, inner);
- if (bitnum != 0)
- inner = build2 (RSHIFT_EXPR, intermediate_type,
- inner, size_int (bitnum));
+ tree bftype = build_nonstandard_integer_type (1, 1);
+ int bitpos = bitnum;
- one = build_int_cst (intermediate_type, 1);
+ if (BYTES_BIG_ENDIAN)
+ bitpos = GET_MODE_BITSIZE (operand_mode) - 1 - bitpos;
- if (code == EQ_EXPR)
- inner = fold_build2_loc (loc, BIT_XOR_EXPR, intermediate_type, inner, one);
+ inner = build3_loc (loc, BIT_FIELD_REF, bftype, inner,
+ bitsize_int (1), bitsize_int (bitpos));
- /* Put the AND last so it can combine with more things. */
- inner = build2 (BIT_AND_EXPR, intermediate_type, inner, one);
+ one = build_int_cst (bftype, 1);
- /* Make sure to return the proper type. */
- inner = fold_convert_loc (loc, result_type, inner);
+ if (code == EQ_EXPR)
+ inner = fold_build2_loc (loc, BIT_XOR_EXPR, bftype, inner, one);
- return inner;
+ return fold_convert_loc (loc, result_type, inner);
}
/* Generate code to calculate OPS, and exploded expression
--
2.17.1
next prev parent reply other threads:[~2023-05-20 2:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 2:14 [PATCH 0/7] Improve do_store_flag Andrew Pinski
2023-05-20 2:14 ` [PATCH 1/7] Move fold_single_bit_test to expr.cc from fold-const.cc Andrew Pinski
2023-05-20 4:43 ` Jeff Law
2023-05-20 2:14 ` [PATCH 2/7] Inline and simplify fold_single_bit_test_into_sign_test into fold_single_bit_test Andrew Pinski
2023-05-20 4:47 ` Jeff Law
2023-05-20 4:48 ` Jeff Law
2023-05-20 2:14 ` [PATCH 3/7] Use get_def_for_expr in fold_single_bit_test Andrew Pinski
2023-05-20 4:49 ` Jeff Law
2023-05-20 2:14 ` [PATCH 4/7] Simplify fold_single_bit_test slightly Andrew Pinski
2023-05-20 4:51 ` Jeff Law
2023-05-20 2:14 ` [PATCH 5/7] Simplify fold_single_bit_test with respect to code Andrew Pinski
2023-05-20 4:52 ` Jeff Law
2023-05-20 2:14 ` Andrew Pinski [this message]
2023-05-20 4:54 ` [PATCH 6/7] Use BIT_FIELD_REF inside fold_single_bit_test Jeff Law
2023-05-20 2:14 ` [PATCH 7/7] Expand directly for single bit test Andrew Pinski
2023-05-20 4:55 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230520021451.1901275-7-apinski@marvell.com \
--to=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).