From: "Marc Poulhiès" <poulhies@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Piotr Trojanek <trojanek@adacore.com>
Subject: [COMMITTED] ada: Cleanup redundant condition in resolution of entity names
Date: Mon, 22 May 2023 10:50:55 +0200 [thread overview]
Message-ID: <20230522085055.1726743-1-poulhies@adacore.com> (raw)
From: Piotr Trojanek <trojanek@adacore.com>
Code cleanup related to new contract for SPARK; semantics is unaffected.
gcc/ada/
* sem_res.adb (Resolve_Entity_Name): Combine two IF statements that
execute code only for references that come from source.
Tested on x86_64-pc-linux-gnu, committed on master.
---
gcc/ada/sem_res.adb | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/gcc/ada/sem_res.adb b/gcc/ada/sem_res.adb
index 3eb13de38df..365c75041a9 100644
--- a/gcc/ada/sem_res.adb
+++ b/gcc/ada/sem_res.adb
@@ -8022,7 +8022,7 @@ package body Sem_Res is
if Comes_From_Source (N) then
- -- The following checks are only relevant when SPARK_Mode is on as
+ -- The following checks are only relevant when SPARK_Mode is On as
-- they are not standard Ada legality rules.
if SPARK_Mode = On then
@@ -8067,13 +8067,11 @@ package body Sem_Res is
if Is_Ghost_Entity (E) then
Check_Ghost_Context (E, N);
end if;
- end if;
- -- We may be resolving an entity within expanded code, so a reference to
- -- an entity should be ignored when calculating effective use clauses to
- -- avoid inappropriate marking.
+ -- We may be resolving an entity within expanded code, so a reference
+ -- to an entity should be ignored when calculating effective use
+ -- clauses to avoid inappropriate marking.
- if Comes_From_Source (N) then
Mark_Use_Clauses (E);
end if;
end Resolve_Entity_Name;
--
2.40.0
reply other threads:[~2023-05-22 8:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522085055.1726743-1-poulhies@adacore.com \
--to=poulhies@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=trojanek@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).