From: "Marc Poulhiès" <poulhies@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Piotr Trojanek <trojanek@adacore.com>
Subject: [COMMITTED] ada: Suppress warning about Subprogram_Variant failing at run time
Date: Tue, 23 May 2023 10:07:47 +0200 [thread overview]
Message-ID: <20230523080747.1872885-1-poulhies@adacore.com> (raw)
From: Piotr Trojanek <trojanek@adacore.com>
Warning about check failing at run time is likely spurious for mutually
recursive subprograms with multiple variant clauses. These will be
non-trivial to detect, so we simply suppress the warning altogether for
all subprogram variants.
gcc/ada/
* exp_prag.adb (Expand_Pragma_Check): Suppress warning for checks of
subprogram variants.
Tested on x86_64-pc-linux-gnu, committed on master.
---
gcc/ada/exp_prag.adb | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/gcc/ada/exp_prag.adb b/gcc/ada/exp_prag.adb
index ceb27848dad..c6b3bed5425 100644
--- a/gcc/ada/exp_prag.adb
+++ b/gcc/ada/exp_prag.adb
@@ -564,6 +564,13 @@ package body Exp_Prag is
then
null;
+ -- For Subprogram_Variant suppress the warning altogether, because
+ -- for mutually recursive subprograms with multiple variant clauses
+ -- some of the clauses might have expressions that are only meant for
+ -- verification and would always fail when executed.
+
+ elsif Nam = Name_Subprogram_Variant then
+ null;
elsif Nam = Name_Assert then
Error_Msg_N ("?.a?assertion will fail at run time", N);
else
--
2.40.0
reply other threads:[~2023-05-23 8:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523080747.1872885-1-poulhies@adacore.com \
--to=poulhies@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=trojanek@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).