From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by sourceware.org (Postfix) with ESMTPS id 8F1DA3882174 for ; Tue, 23 May 2023 08:08:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F1DA3882174 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3f42ba32e24so45431935e9.3 for ; Tue, 23 May 2023 01:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1684829324; x=1687421324; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WpAgK+oel6MhOBLl9dDPkOT84jb9o0MiJhHSX/iyjG8=; b=fJxhs4e1PS7tVI69yXtaZswilmXiPUqH0J1wWZmoG1dOHX7SWh6NJx4uF42udbMZ0F DFqC49Rn3rk9Zls/PJhcGIzh/URQtMMX2JurG4TmqGjGxLY/L1vxukFLUeP2uKA28Xmh idjrPZISd8KHvDlbbRXJglBjZjpd0imtTv1+fxl5Vx9EZSkjU9fYTATNdnIxnHk7PLyA z2rFS+cmlZiFmTVACigEgXjEpEs0Ub3wfXjK0AqSC7Ha9rCy2z4eJH731poFetAlXLlO 9EahXeeManDbceWnQr9CE3oSgZcq+EIUrV3YYhJDbxEqbgM+nHEf7NNPLisy3y1mWMje 8ypg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684829324; x=1687421324; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WpAgK+oel6MhOBLl9dDPkOT84jb9o0MiJhHSX/iyjG8=; b=YUVPeix/Izm7yfs+P7lLMz8fQbMDHW3ExhT4eYGUprD3yCuNPEfkLdMY2cUBRtIpZg s7DqfRAinKI/2iu0IdAv5/mgnpa4+ZXC6VHs9aYMvqAKHZz2u6kKq5Bcc29FoDFjQn4I 5MM0DspxmaRrzSL/hxUa34TYOOzbBSvwAdBkz1uEUiOVBkPb/YLVCivzLY2X7SErAyLI Zo1KYS68innj5Fs2/gv7ZfCNGMHVBdiVwBPHrlVcPw/8o7ZGAf3ifV0Ey5rChZ0cqsb0 SFt5/u35xSmz7xVQKyGILOcK9ugPW6gAzpXGK9LLgpKdvj71ASM+6y8qXcjctd959WO7 Icbg== X-Gm-Message-State: AC+VfDzrnPXldYXW544v5QjnRctSidZl64pHmuGrXqht9xlHyvxD5b4b pOd6cTpZUTpwczmauLiaTG09bgBdrPUyEMdBLaEeLw== X-Google-Smtp-Source: ACHHUZ7OrseVecIFnctE7VMEnj60RTdEJoiFUSd8tvCVuCJBoe+9OYCZQLVTqjyc1c3QFXOvB9Nptg== X-Received: by 2002:a05:600c:2257:b0:3f6:900:4b6a with SMTP id a23-20020a05600c225700b003f609004b6amr1653847wmm.1.1684829324387; Tue, 23 May 2023 01:08:44 -0700 (PDT) Received: from poulhies-Precision-5550.telnowedge.local (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id s4-20020a5d4244000000b00307bc4e39e5sm10104355wrr.117.2023.05.23.01.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 01:08:43 -0700 (PDT) From: =?UTF-8?q?Marc=20Poulhi=C3=A8s?= To: gcc-patches@gcc.gnu.org Cc: Vadim Godunko Subject: [COMMITTED] ada: Remove unnecessary call to Detach. Date: Tue, 23 May 2023 10:08:42 +0200 Message-Id: <20230523080842.1874165-1-poulhies@adacore.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Vadim Godunko Holder object is constant and protected from modification by tampering rules. gcc/ada/ * libgnat/a-coinho__shared.adb (Constant_Reference): Remove call of Detach (Query_Element): Likewise. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/libgnat/a-coinho__shared.adb | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gcc/ada/libgnat/a-coinho__shared.adb b/gcc/ada/libgnat/a-coinho__shared.adb index 367089048af..f49ac4ad817 100644 --- a/gcc/ada/libgnat/a-coinho__shared.adb +++ b/gcc/ada/libgnat/a-coinho__shared.adb @@ -149,8 +149,6 @@ package body Ada.Containers.Indefinite_Holders is raise Constraint_Error with "container is empty"; end if; - Detach (Container); - declare Ref : constant Constant_Reference_Type := (Element => Container.Reference.Element.all'Access, @@ -305,8 +303,6 @@ package body Ada.Containers.Indefinite_Holders is raise Constraint_Error with "container is empty"; end if; - Detach (Container); - B := B + 1; begin -- 2.40.0