From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DC2B13858D37 for ; Thu, 25 May 2023 05:35:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC2B13858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684992927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wFffVv322eOKeXj42oV33TouzBLYe9Z7Uf7AwIRQYKo=; b=MkaL3wM7FOMiQ14fvMxuljSUoAtTFz9WeRCz7IQol5PRmht0z/3NYkLcUFK6udUXtvaW4T 7u/BYSkjz+CtXqxHJb2+mx648Tv7pcquDxv5oYDWu12fdJby0RH416kR3ccn66IvrgTUba xyEFl5wC+o+RoYgPIS9BvyDhdrbcSPE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-EsFuJAbuN4qgiCzFjDHDWQ-1; Thu, 25 May 2023 01:35:26 -0400 X-MC-Unique: EsFuJAbuN4qgiCzFjDHDWQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BBC773C0CEFF for ; Thu, 25 May 2023 05:35:25 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.192.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 53EBD9D73; Thu, 25 May 2023 05:35:25 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 34P5ZN80244698 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 25 May 2023 07:35:23 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 34P5ZN3T244697; Thu, 25 May 2023 07:35:23 +0200 From: Aldy Hernandez To: GCC patches Cc: Andrew MacLeod , Aldy Hernandez Subject: [COMMITTED] Hash known NANs correctly for franges. Date: Thu, 25 May 2023 07:35:18 +0200 Message-Id: <20230525053520.244673-2-aldyh@redhat.com> In-Reply-To: <20230525053520.244673-1-aldyh@redhat.com> References: <20230525053520.244673-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: We're ICEing when trying to hash a known NAN. This is unnoticeable because the only user would be IPA, and even so, it currently doesn't handle floats. However, handling floats is a flip of a switch, so it's best to handle them already. gcc/ChangeLog: * value-range.cc (add_vrange): Handle known NANs. --- gcc/value-range.cc | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/gcc/value-range.cc b/gcc/value-range.cc index 874a1843ebf..2f37ff3e58e 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -269,14 +269,14 @@ add_vrange (const vrange &v, inchash::hash &hstate, if (is_a (v)) { const frange &r = as_a (v); - if (r.varying_p ()) - hstate.add_int (VR_VARYING); + if (r.known_isnan ()) + hstate.add_int (VR_NAN); else - hstate.add_int (VR_RANGE); - - hstate.add_real_value (r.lower_bound ()); - hstate.add_real_value (r.upper_bound ()); - + { + hstate.add_int (r.varying_p () ? VR_VARYING : VR_RANGE); + hstate.add_real_value (r.lower_bound ()); + hstate.add_real_value (r.upper_bound ()); + } nan_state nan = r.get_nan_state (); hstate.add_int (nan.pos_p ()); hstate.add_int (nan.neg_p ()); -- 2.40.1