From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2091.outbound.protection.outlook.com [40.107.247.91]) by sourceware.org (Postfix) with ESMTPS id 8B40E388BC81 for ; Mon, 29 May 2023 10:33:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B40E388BC81 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=Syrmia.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Syrmia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eH6fjdjt6hWi9da9fF1u4s4JHAQYPK6xlvSVZ10wmHYGc/CQOZBcMiGY/Gijg9WbkPsg2Ys6bhbL2NFWRlAJyW2OAboj5jQlGV5YCtXVZeQEMQC7LRW+0xU3Rg1nXSzZEMS7kzsARS8e+IJKShC72HZPhdNIu1s8Gy7LAM0gP7gjrEX98DBjwFksIr6wsnpXLYn5+AU7lrhnX7tBYDGVwAsTk8IMinAHcoI/zlPl2s2zu8nBSiNeevAbmbEi0oMXaKEDaH7hkdx/7bWoa3w75tkbzLqNDHXc8NA5a3+P2ovWPdv6rzkb3nFqWgy6bmPEsubm+2niPtMSxWUmX7w5nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vt3YcBmnVuP2gbwgnXk2s3QSu5tert5lrDEF09GJwsQ=; b=JyNKlqnadoEa5w78coXbUiJIrt3+G0sPNy4Pi1Smv7VKSYmNYuFYa2aEy0VAqK8hyBnDZyQ8oFj2/Onzm8jheBNBqZns+xm366kaouAourSgOY+3Hc2Lk4nDVLs8frJTEYwohFQBkUByrfRfr7+AQX6IHgZbQO1J9pTuui9CVI69M0U68MXwHX2fE0xGr4OZVcFkSeD670SZr7OlJbwOmBZiSByZ54e5muftf7/zgSpBGC8prehBSwGb8Q5HhogRIFes493HZw5cqg5PSZw2vmdHg9wAZNW4oCHC2OTBWZQZl6XbjWbKw4hdhFwC6Y9Z7dSctgHraOnJY1ae+nRd/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=syrmia.com; dmarc=pass action=none header.from=syrmia.com; dkim=pass header.d=syrmia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syrmia.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vt3YcBmnVuP2gbwgnXk2s3QSu5tert5lrDEF09GJwsQ=; b=AVHfmJOVYvU+TqJDdnAk85fwgR1C7rIXAJVaiDotI1Qlk20SjwvPqlwDDNGif3hfPrZLoDEh9bLMhCw5SPIh1K4XGkrW5YITyjK+Oglvn7twTDAAa/UkVADSRIPChFj6KCSx/tozYjbNpMjs6BDmVBIhnQ1Gv48OMO2Xd5mkqek= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=Syrmia.com; Received: from DB9PR03MB7163.eurprd03.prod.outlook.com (2603:10a6:10:1ff::9) by VI1PR03MB9939.eurprd03.prod.outlook.com (2603:10a6:800:1ce::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.22; Mon, 29 May 2023 10:33:28 +0000 Received: from DB9PR03MB7163.eurprd03.prod.outlook.com ([fe80::a3ea:bbc0:9e7b:b472]) by DB9PR03MB7163.eurprd03.prod.outlook.com ([fe80::a3ea:bbc0:9e7b:b472%7]) with mapi id 15.20.6433.022; Mon, 29 May 2023 10:33:28 +0000 From: Jovan Dmitrovic To: gcc-patches@gcc.gnu.org Cc: djordje.todorovic@syrmia.com, Jovan Dmitrovic , Jovan Dmitrovic Subject: [PATCH] mips: Fix overaligned function arguments [PR109435] Date: Mon, 29 May 2023 12:32:54 +0200 Message-Id: <20230529103254.2753472-1-Jovan.Dmitrovic@Syrmia.com> X-Mailer: git-send-email 2.34.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SJ2PR07CA0011.namprd07.prod.outlook.com (2603:10b6:a03:505::20) To DB9PR03MB7163.eurprd03.prod.outlook.com (2603:10a6:10:1ff::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR03MB7163:EE_|VI1PR03MB9939:EE_ X-MS-Office365-Filtering-Correlation-Id: 72ec4b3b-e167-4af9-1bcb-08db60302438 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n9Tlo90W33FKkNtJJf/8f5JbZ5dxsp+i2lkBz3OMYiDbN4HZ4o7waKXb2HHEMTG2lcrhA+oMrfncGvfs807/nVOhr5hfT4oQG8jKFJFP3kgjimE3B097dXf91wd1ScmuItwIefr/SiM1B2umBFEJPpTADFMrgkFUaDctZ7DAvC9DElM2TKK+hJz1xZYt8pC8Z6WR0Q6RJGEkgq22a1xU6rxQywiJlx5OdX1w8sqXsEZwdqCXDAaH3v/vpcqNNKLFePJHWLZb6hhHsnt4q0oO9Z0VM0vRPp+WG8yu4VuG33xtJoO1U9IqA3N3za0TdEgUe+mDaR9J5YivN12yk2zqZ3v/BwQZak7bLTT0yeS0yOVD8m8pkGELAR6zlRIGaVFIaFUSefcG6gUCjbB0bTZdLXEffd+q1UH+pG3jn2DSqG5iHd4xSl7A4t3SVgni1PPHRO8LtrMVgWGPbnXcVKgKX09Bzh6vrO6vWkvZ7u8f40dIiHh8PgR3442lZJCFo8NJyku6zdk+FAS/VMJLratp6GPz7tGbsilIeXM3yTbwaLEDnbFHZGvHz/di4W7PGZ6F4GrmDEZetevjQk3/nR69FgEs9LaVqvLTkz5z0TJO2s0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR03MB7163.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(136003)(39830400003)(376002)(346002)(451199021)(6512007)(6506007)(186003)(2906002)(2616005)(54906003)(26005)(478600001)(1076003)(84970400001)(83380400001)(52116002)(86362001)(8936002)(6486002)(38100700002)(38350700002)(41300700001)(8676002)(5660300002)(66476007)(36756003)(6666004)(316002)(66946007)(66556008)(107886003)(6916009)(4326008);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BdS3Its66YG20spb/t5R2tfTUQ8ND3eULW+e/e7cFdZNrVBUwqNdC7jd7MG6?= =?us-ascii?Q?ej4NmMnBtyrLpuRwVw0mhohgaieOwOyTWpMQkNwJ0oec1Iu6ERLFDrvNr2EB?= =?us-ascii?Q?4mxxoVy64q/ao+Jzvjo8+Aayjd/sHdchJdeifevmErNC5HtZ2udRpcH7teyM?= =?us-ascii?Q?zh1vv42CFAOhSHdVyhUsaYjaVeRf344CfEM/xkiOYx8EAH2PqEANpmZ7w3LR?= =?us-ascii?Q?hXmP5pzhYX+6dN1CZ2nYEp1Zs7oJuc1Uv1+gdk5vWjVemm0ik5rIjVAc3XYB?= =?us-ascii?Q?/abYRWjct7u3FFFflAblRsh0VbDvZkBX/kymOlL4ts5DrgDw29dTHOWe5PKX?= =?us-ascii?Q?xSRkv9hQOxXld+WFu11gslNl71BV9lMoSyPIkx6R1z7hHSq8x+b+KCOlFI9L?= =?us-ascii?Q?jGbDK6VNavhl4FZeOdU2+vGwD8Pp2bfF7hgdzGPO1nfYhkUNVGerT4a7mfkO?= =?us-ascii?Q?vMQg3hHIPj51AKKIhktwJoXY3dJjL9+pxj1Ve80pIRZImxZFBBXRzRhukX+t?= =?us-ascii?Q?lWstk1iKOCNsRpNaDEdQ2KeyQ+3ujmfESmOog30EZk99j4SeSgd+FxDghRZs?= =?us-ascii?Q?+tFKgH7ajdQroRA8OcjKimWxVm4WYMaW70EGWItozIgRJt+11QqV4aRscfS4?= =?us-ascii?Q?jrHKgRl42a477DX2etv6wV2EeuN9iavXZcxjDrXR9zpnqgKovlj6YrgZAUZv?= =?us-ascii?Q?NQpYTKC1SeR7SCiZDsF9a5xs/0Lo+0icKkX3nmtGCUhhfdlhgrXbUrrcFl/u?= =?us-ascii?Q?V0k6+xL3LTVx32RxqCvjTv25NtGZIf05ZVPl0BcnaFgIZKCw93R0B5tRS9oA?= =?us-ascii?Q?Rh39ibDWXbMfIbpQYz/wlIETv0xDwttiGxI27FVoSqOScHoAFASfHtXvL+jb?= =?us-ascii?Q?NUnpedhgXKULPZRsm9K95XOaO6usRckk/Hvhy9LfG+iz/SjGQYkWx2bzNKdF?= =?us-ascii?Q?M+dtBVlhD5hsoRYBAbNQ7uNka2ALBPnvn+kfeU0Hg1FcbBLzIgCwq15WWHWO?= =?us-ascii?Q?FkyvBR/n1jBmXWIxXkAUg3aVJt0Laf9dcVI+KancxSND5Yd2I3KJGETkpY9o?= =?us-ascii?Q?w0Q7J0RBHQqBB3HHgpsSmo6DpOkKBYjELKkad8JBIMzLKBdHipDpmjeN9Eqr?= =?us-ascii?Q?vJCfxpO68kETRyvpIqpK+Fs7bY4ArXugg1OrBDMDZUCxvFiWCEgVtnuCVTho?= =?us-ascii?Q?INGkpnyhbuz2fw46yHJDur+72iaaa68fPCVomjqKyhaaDv/I8vvz1Mgp+Pk6?= =?us-ascii?Q?KqGSZcsieoFgNbJl1s4zg26ATSKjGJtMeyZEO69Frlw66Rml4VSHEoJ6b3q1?= =?us-ascii?Q?wUoZsqD62hGMeO8VlQe+IZysAN/0+p2ncj3hn+f2c9b3YLvM1pCOsSmS2mFU?= =?us-ascii?Q?ZmPf83sxPbZgwCXMM25QsoJXMgP18M+BSFEecpS6DxZkN+5eOvNsBcjrF97s?= =?us-ascii?Q?cfN24a1iCDFH3bdV/HKjFVyYVQKsYyGF8ISAtlvtYvGZMekmwfB8Huhqo/cu?= =?us-ascii?Q?t6mkBXQA7dnoMN9+raG/KRKrxvTdOn4Ehev1YPDYi3Io2E/aAUx8ku3UfSze?= =?us-ascii?Q?bCb6h4HifhFbccUms2xSGg2d65lIlNEj8v5f70+octDBrXdxTSzg+HwxtFyT?= =?us-ascii?Q?gA=3D=3D?= X-OriginatorOrg: syrmia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72ec4b3b-e167-4af9-1bcb-08db60302438 X-MS-Exchange-CrossTenant-AuthSource: DB9PR03MB7163.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2023 10:33:28.8025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 19214a73-c1ab-4e19-8f59-14bdcb09a66e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nVn7cJnAOc9xprf3Dk8Rxh2qojcRaWmL/BoddLNK4yP25bDxEODMiRXRPPC52dSb3yILrgwsgpt072gcgYH7i9btJJv1fLh2jjM2As/shLo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB9939 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This patch changes alignment for typedef types when passed as arguments, making the alignment equal to the alignment of original (aliased) types. This change makes it impossible for a typedef type to have alignment that is less than its size. Signed-off-by: Jovan Dmitrovic gcc/ChangeLog: PR target/109435 * config/mips/mips.cc (mips_function_arg_alignment): Returns the alignment of function argument. In case of typedef type, it returns the aligment of the aliased type. (mips_function_arg_boundary): Relocated calculation of the aligment of function arguments. gcc/testsuite/ChangeLog: PR target/109435 * gcc.target/mips/align-1.c: New test. --- gcc/config/mips/mips.cc | 18 +++++++++++++- gcc/testsuite/gcc.target/mips/align-1.c | 33 +++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/mips/align-1.c diff --git a/gcc/config/mips/mips.cc b/gcc/config/mips/mips.cc index ca822758b41..2019b7cd7d9 100644 --- a/gcc/config/mips/mips.cc +++ b/gcc/config/mips/mips.cc @@ -6190,6 +6190,22 @@ mips_arg_partial_bytes (cumulative_args_t cum, const function_arg_info &arg) return info.stack_words > 0 ? info.reg_words * UNITS_PER_WORD : 0; } +/* Given MODE and TYPE of a function argument, return the alignment in + bits. In case of typedef, alignment of its original type is + used. */ + +static unsigned int +mips_function_arg_alignment (machine_mode mode, const_tree type) +{ + if (!type) + return GET_MODE_ALIGNMENT (mode); + + if (is_typedef_decl (TYPE_NAME (type))) + type = DECL_ORIGINAL_TYPE (TYPE_NAME (type)); + + return TYPE_ALIGN (type); +} + /* Implement TARGET_FUNCTION_ARG_BOUNDARY. Every parameter gets at least PARM_BOUNDARY bits of alignment, but will be given anything up to STACK_BOUNDARY bits if the type requires it. */ @@ -6198,8 +6214,8 @@ static unsigned int mips_function_arg_boundary (machine_mode mode, const_tree type) { unsigned int alignment; + alignment = mips_function_arg_alignment (mode, type); - alignment = type ? TYPE_ALIGN (type) : GET_MODE_ALIGNMENT (mode); if (alignment < PARM_BOUNDARY) alignment = PARM_BOUNDARY; if (alignment > STACK_BOUNDARY) diff --git a/gcc/testsuite/gcc.target/mips/align-1.c b/gcc/testsuite/gcc.target/mips/align-1.c new file mode 100644 index 00000000000..816751b8099 --- /dev/null +++ b/gcc/testsuite/gcc.target/mips/align-1.c @@ -0,0 +1,33 @@ +/* Check that typedef alignment does not affect passing of function + parameters. */ +/* { dg-do run { target { "mips*-*-linux*" } } } */ + +#include + +typedef struct ui8 +{ + unsigned v[8]; +} uint8 __attribute__ ((aligned(64))); + +unsigned +callee (int x, uint8 a) +{ + return a.v[0]; +} + +uint8 +identity (uint8 in) +{ + return in; +} + +int +main (void) +{ + uint8 vec = {{1, 2, 3, 4, 5, 6, 7, 8}}; + uint8 temp = identity (vec); + unsigned temp2 = callee (1, identity (vec)); + assert (callee (1, temp) == 1); + assert (temp2 == 1); + return 0; +} -- 2.34.1