From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by sourceware.org (Postfix) with ESMTPS id DF4AC3858D20 for ; Tue, 30 May 2023 14:00:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF4AC3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-19f7f41d9dcso1284796fac.2 for ; Tue, 30 May 2023 07:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685455233; x=1688047233; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4JLpAzy0juXy4uPEW9+KbXrgS4Tos8zyTS+ZKw3ITKg=; b=pLYr8Q94CHdn7q0+ZU9UaBkZaxwShBc4CXPy36il+fxvDQgh+1MO/LqPJsiX4VNssR KabyypUqmlcO3ZhLkZYdXUeyBmDJsd/4DK6UDE2aON10hV3XHa2wT8eT7+bRbsSOckBS 9cztM+996u3/X2cznS01JPTWwHtRlmR0pYVEQU02GUqLNdiFMwGVxMu8D6pFnXXSgaik QTi/OAW/Cle20BMlf2FYTjubFmc7MPOjcOrq7Dd/ESxDvtXGi1WVM/oWFvRRo+wyuKGw l7sx3XA4zI00HtJOzojgx1NzHr3fAZvG39EgtloPOKzxYbHiNJY8NLp7XNKkP9kZ1+J/ dsEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685455233; x=1688047233; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4JLpAzy0juXy4uPEW9+KbXrgS4Tos8zyTS+ZKw3ITKg=; b=I4BENbKmotPTujhUErbNAxOlRHvXAdvGDzn4otrre0OEEg2mtATEbdDN1BXXdB/xhL O3BYAds3IP5buWoezzTmNyqPZb3o2kKj5W3CQe6f2Oi6s80zig3QjE6pPrJJVerBZsKL N6DWVpAxCXn40IfshafPlbZ1bKAGSj5hcRcP7sfgjCPEhNoq1ddsDR7kEQesR3LUH4a5 9qnEVhGbxN78fMeosntcL9P/MzcQqJO296myR1gDgjVjDBgWddg944y+YJeQG7RuHqkE kA/EBAsm/ByIPjTJu54BE4XAf64lDMgJ/uoDFnRw2h06SqpNo3s1F815N245hYyuKbiW IAtQ== X-Gm-Message-State: AC+VfDwuRZc724ci60a3fLnaeUuwewTw7ve1qA/7M35M9GG7KPUFOhcD PGO63ODIFXVatMbkVeEj0Q8hy4/wvrullnlx+VUgcQ== X-Google-Smtp-Source: ACHHUZ4amQ70Aq0F1ReomN+csZ5Mthejq/SyktCMq+3jmS1/S1HfxObIpism1Zr0G/y6rSwKOMbdGg== X-Received: by 2002:a05:6870:b6a5:b0:18f:57b0:a952 with SMTP id cy37-20020a056870b6a500b0018f57b0a952mr1299982oab.15.1685455232757; Tue, 30 May 2023 07:00:32 -0700 (PDT) Received: from localhost.localdomain ([139.178.84.207]) by smtp.gmail.com with ESMTPSA id g4-20020a056870340400b001718e65a5d0sm5774521oah.57.2023.05.30.07.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 07:00:32 -0700 (PDT) From: Christophe Lyon To: gcc-patches@gcc.gnu.org, Kyrylo.Tkachov@arm.com, chris.sidebottom@arm.com Cc: Christophe Lyon Subject: [PATCH] [arm][testsuite]: Fix ACLE data-intrinsics testcases Date: Tue, 30 May 2023 14:00:20 +0000 Message-Id: <20230530140020.1108499-1-christophe.lyon@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: data-intrinsics-assembly.c forces -march=armv6 using dg-add-options arm_arch_v6, which implicitly adds -mfloat-abi=softfp. However, for a toolchain configured for arm-linux-gnueabihf and --with-arch=armv7-a, the testcase will fail when including arm_acle.h (which includes stdint.h, which will fail to include the non-existing gnu/stubs-soft.h). Other effective-targets related to arm_acle.h would also pass because they first try without -mfloat-abi=softfp, so it seems the simplest/safest is to add { dg-require-effective-target arm_softfp_ok } to make sure arm_arch_v6_ok's assumption is valid. The patch also fixes what seems to be an oversight in data-intrinsics-armv6.c: it requires arm_arch_v6_ok, but uses arm_arch_v6t2: the patch makes it require arm_arch_v6t2_ok. 2023-05-30 Christophe Lyon gcc/testsuite/ * gcc.target/arm/acle/data-intrinsics-armv6.c: Fix typo. * gcc.target/arm/acle/data-intrinsics-assembly.c Require arm_softfp_ok. --- gcc/testsuite/gcc.target/arm/acle/data-intrinsics-armv6.c | 2 +- gcc/testsuite/gcc.target/arm/acle/data-intrinsics-assembly.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-armv6.c b/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-armv6.c index aafdff35cee..988ecac3787 100644 --- a/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-armv6.c +++ b/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-armv6.c @@ -1,5 +1,5 @@ /* { dg-do run } */ -/* { dg-require-effective-target arm_arch_v6_ok } */ +/* { dg-require-effective-target arm_arch_v6t2_ok } */ /* { dg-add-options arm_arch_v6t2 } */ #include "arm_acle.h" diff --git a/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-assembly.c b/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-assembly.c index 3e066877a70..478cbde1600 100644 --- a/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-assembly.c +++ b/gcc/testsuite/gcc.target/arm/acle/data-intrinsics-assembly.c @@ -1,5 +1,6 @@ /* Test the ACLE data intrinsics get expanded to the correct instructions on a specific architecture */ /* { dg-do assemble } */ +/* { dg-require-effective-target arm_softfp_ok } */ /* { dg-require-effective-target arm_arch_v6_ok } */ /* { dg-additional-options "--save-temps -O1" } */ /* { dg-add-options arm_arch_v6 } */ -- 2.34.1